Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 15941005: Merged r14732, r14746, r14757 into 3.18 branch. (Closed)

Created:
7 years, 7 months ago by Yang
Modified:
7 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Merged r14732, r14746, r14757 into 3.18 branch. Zap map value in the stub-cache on clear. The empty_string is a valid key for keyed loads and stores. Fix unexpected elements transition in JSON.parse Fix bogus deopt in BuildEmitDeepCopy for holey arrays. BUG=241344, chromium:242924 R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -38 lines) Patch
M src/hydrogen.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +13 lines, -3 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-241344.js View 1 chunk +9 lines, -19 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-242924.js View 1 chunk +15 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 7 months ago (2013-05-24 11:26:13 UTC) #1
Toon Verwaest
lgtm
7 years, 7 months ago (2013-05-24 11:43:33 UTC) #2
Yang
7 years, 7 months ago (2013-05-24 11:46:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14799 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698