Add HasWord(string) method to SpellcheckCustomDictionary

chrome/browser/ui/webui/options/language_dictionary_overlay_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/language_dictionary_overlay_handler.h"
 
 #include "base/bind.h"
 #include "base/values.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/spellchecker/spellcheck_factory.h"
@@ skipping 73 matching lines @@
   if (!overlay_initialized_)
     return;
 
   if (!dictionary_) {
     dictionary_ = SpellcheckServiceFactory::GetForProfile(
         Profile::FromWebUI(web_ui()))->GetCustomDictionary();
     dictionary_->AddObserver(this);
   }
 
   ListValue list_value;
-  list_value.AppendStrings(dictionary_->GetWords());
+  const chrome::spellcheck_common::WordSet& words = dictionary_->GetWords();
+  for (chrome::spellcheck_common::WordSet::iterator it = words.begin();

[Dan Beam, 2013/05/24 02:57:51]

nit: const_iterator

[Dan Beam, 2013/05/24 02:57:51]

wouldn't it be nice to use auto here?!  what a mouthful...

[please use gerrit instead, 2013/05/24 16:20:01]

Done.

+       it != words.end();

[Dan Beam, 2013/05/24 02:57:51]

nit: it's probably pretty normal to put

  it != words.end(); ++it) {

on the same line

[please use gerrit instead, 2013/05/24 16:20:01]

Done.

+       ++it) {
+    list_value.AppendString(*it);
+  }
   web_ui()->CallJavascriptFunction("EditDictionaryOverlay.setWordList",
                                    list_value);
 }
 
 void LanguageDictionaryOverlayHandler::RefreshWords(const ListValue* args) {
   overlay_initialized_ = true;
   ResetDictionaryWords();
 }
 
 void LanguageDictionaryOverlayHandler::AddWord(const ListValue* args) {
   std::string new_word;
   if (!args->GetString(0, &new_word) || new_word.empty() || !dictionary_) {
     NOTREACHED();
     return;
   }
   dictionary_->AddWord(new_word);
 }
 
 void LanguageDictionaryOverlayHandler::RemoveWord(const ListValue* args) {
   std::string old_word;
   if (!args->GetString(0, &old_word) || old_word.empty() || !dictionary_) {
     NOTREACHED();
     return;
   }
   dictionary_->RemoveWord(old_word);
 }
 
 }  // namespace options