Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 15939004: [content shell] Do not disable cc-driven animation when using threaded compositing (Closed)

Created:
7 years, 7 months ago by ajuma
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, Ian Vollick
Visibility:
Public.

Description

[content shell] Do not disable cc-driven animation when using threaded compositing The kDisableThreadedAnimation flag, which actually disables cc-driven animations regardless of whether we're using a compositor thread, is currently set for all layout tests. We need to set this flag in single thread mode (which is the default for layout tests) since, in this mode, cc-driven animations cause never-ending invalidation, causing tests to fail. However, when threaded compositing is enabled, cc-driven animations do not cause never-ending invalidation. This CL makes us only disable cc-driven animations when in single thread mode. This is a prerequisite for creating a virtual test suite for animations that uses threaded compositing and threaded animation. BUG=244266 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/shell/app/shell_main_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ajuma
7 years, 7 months ago (2013-05-27 19:15:25 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 7 months ago (2013-05-27 19:18:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/15939004/1
7 years, 6 months ago (2013-05-28 13:08:29 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 16:33:35 UTC) #4
Message was sent while issue was closed.
Change committed as 202583

Powered by Google App Engine
This is Rietveld 408576698