Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 15937004: Respect Android system settings for allowing the last character of a password to be displayed. (Closed)

Created:
7 years, 7 months ago by cimamoglu (inactive)
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Respect Android system settings for allowing the last character of a password to be displayed. This CL is only the Chromium part of the whole change, i.e. does not include Android changes. BUG=148796 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/defaults.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
cimamoglu (inactive)
The setting in Android can be reached via Settings -> Security -> Make passwords visible. ...
7 years, 7 months ago (2013-05-24 14:36:56 UTC) #1
jam
removing myself as a reviewer (see note in chrome/OWNERS)
7 years, 6 months ago (2013-05-28 17:56:52 UTC) #2
Ramya
lgtm
7 years, 6 months ago (2013-06-03 22:53:47 UTC) #3
cimamoglu (inactive)
Hi Jochen! Can you please approve the changes?
7 years, 6 months ago (2013-06-04 10:44:25 UTC) #4
jochen (gone - plz use gerrit)
not sure I understand this, but the CL seems not to achieve what the description ...
7 years, 6 months ago (2013-06-04 10:50:58 UTC) #5
cimamoglu1
This CL has just the Chromium part, the other part of the code is at ...
7 years, 6 months ago (2013-06-04 10:54:24 UTC) #6
jochen (gone - plz use gerrit)
lgtm can you please update the CL description to reflect that this is only part ...
7 years, 6 months ago (2013-06-04 10:58:16 UTC) #7
cimamoglu (inactive)
On 2013/06/04 10:58:16, jochen wrote: > lgtm > > can you please update the CL ...
7 years, 6 months ago (2013-06-04 11:02:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cimamoglu@chromium.org/15937004/1
7 years, 6 months ago (2013-06-04 11:03:08 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 20:39:09 UTC) #10
Message was sent while issue was closed.
Change committed as 204032

Powered by Google App Engine
This is Rietveld 408576698