Change loading custom auth extension to load from --auth-ext-path value.

Change loading custom auth extension to load from --auth-ext-path value.

Before, if a custom auth extension is given through the --auth-ext-path flag,
the manifest is loaded from the browser resource rather than the overriden
path. We want to load the manifest from the given path instead. 
Also change ComponentLoader::AddOrReplace to return an empty string on failure
for consistency with other ComponentLoader functions.

BUG=239212
TEST=on cros device with custom telemetry auth extension

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202926

[Tim Song, 2013-05-23 22:21:47]

This change is needed so we can log something meaningful when we fail to load
the auth extension. Can you take a quick look?

[achuithb, 2013-05-23 22:34:47]

https://codereview.chromium.org/15937003/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/component_loader.cc (right):

https://codereview.chromium.org/15937003/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/component_loader.cc:170: return std::string();
let's split this file out of this CL.

https://codereview.chromium.org/15937003/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/scoped_gaia_auth_extension.cc (right):

https://codereview.chromium.org/15937003/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/scoped_gaia_auth_extension.cc:37: std::string
extension_id =
let's make this const

https://codereview.chromium.org/15937003/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/scoped_gaia_auth_extension.cc:42: << "--auth-ext-path
flag: " << auth_extension_path.value();
nit: let's use switches::kAuthExtensionPath instead of --auth-ext-path in the
debug stmt.

[Tim Song, 2013-05-23 23:07:05]

https://codereview.chromium.org/15937003/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/scoped_gaia_auth_extension.cc (right):

https://codereview.chromium.org/15937003/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/scoped_gaia_auth_extension.cc:37: std::string
extension_id =
On 2013/05/23 22:34:47, achuith.bhandarkar wrote:
> let's make this const

Done.

https://codereview.chromium.org/15937003/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/scoped_gaia_auth_extension.cc:42: << "--auth-ext-path
flag: " << auth_extension_path.value();
On 2013/05/23 22:34:47, achuith.bhandarkar wrote:
> nit: let's use switches::kAuthExtensionPath instead of --auth-ext-path in the
> debug stmt.

Done.

[achuithb, 2013-05-23 23:08:59]

lgtm

https://codereview.chromium.org/15937003/diff/7001/chrome/browser/extensions/...
File chrome/browser/extensions/scoped_gaia_auth_extension.cc (right):

https://codereview.chromium.org/15937003/diff/7001/chrome/browser/extensions/...
chrome/browser/extensions/scoped_gaia_auth_extension.cc:40: if
(extension_id.empty())
Sorry, didn't notice this before, but you need curly braces for multi-line. {}

[achuithb, 2013-05-23 23:11:12]

not lgtm.

Where are the changes to AddOrReplace?

[Tim Song, 2013-05-23 23:12:31]

+asargent

Can you take a look at this change to chrome/browser/extensions?

[achuithb, 2013-05-23 23:12:40]

On 2013/05/23 23:11:12, achuith.bhandarkar wrote:
> not lgtm.
> 
> Where are the changes to AddOrReplace?

Never mind, I realized they are in the other CL. Please update the description
of this CL as necessary.

[Tim Song, 2013-05-23 23:15:20]

I moved the AddOrReplace changes to another CL as you suggested.

https://codereview.chromium.org/15937003/diff/7001/chrome/browser/extensions/...
File chrome/browser/extensions/scoped_gaia_auth_extension.cc (right):

https://codereview.chromium.org/15937003/diff/7001/chrome/browser/extensions/...
chrome/browser/extensions/scoped_gaia_auth_extension.cc:40: if
(extension_id.empty())
On 2013/05/23 23:08:59, achuith.bhandarkar wrote:
> Sorry, didn't notice this before, but you need curly braces for multi-line. {}

This is a single statement, so it should be work fine, but for clarity you are
right. Done.

[achuithb, 2013-05-23 23:17:00]

lgtm again.

[achuithb, 2013-05-23 23:17:46]

https://codereview.chromium.org/15937003/diff/7001/chrome/browser/extensions/...
File chrome/browser/extensions/scoped_gaia_auth_extension.cc (right):

https://codereview.chromium.org/15937003/diff/7001/chrome/browser/extensions/...
chrome/browser/extensions/scoped_gaia_auth_extension.cc:40: if
(extension_id.empty())
On 2013/05/23 23:15:20, tengs wrote:
> On 2013/05/23 23:08:59, achuith.bhandarkar wrote:
> > Sorry, didn't notice this before, but you need curly braces for multi-line.
{}
> 
> This is a single statement, so it should be work fine, but for clarity you are
> right. Done.
> 

Yup, I believe we have an explicit rule in the style guide about this.

[asargent_no_longer_on_chrome, 2013-05-28 18:30:44]

+cc courage as FYI, since I know he's been doing some changes in this area of
code as well. 

lgtm

[commit-bot: I haz the power, 2013-05-28 20:18:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tengs@chromium.org/15937003/13001

[commit-bot: I haz the power, 2013-05-29 01:34:02]

Retried try job too often on win_rel for step(s) chrome_frame_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-05-29 17:41:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tengs@chromium.org/15937003/13001

[commit-bot: I haz the power, 2013-05-29 19:00:00]

Change committed as 202926