Issue 15936003: [SPDY] Refactor SpdyStream::Delegate

Issue 15936003: [SPDY] Refactor SpdyStream::Delegate (Closed)

Created:
7 years, 7 months ago by akalin

Modified:
7 years, 6 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[SPDY] Refactor SpdyStream::Delegate Merge some member functions and rename others. Clean up SpdyHttpStream logic a bit. BUG=243643 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202703

Patch Set 1 #

Patch Set 2 : More SpdyHttpStream cleanup #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Address comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -217 lines)			Patch
M	net/spdy/spdy_http_stream.h	View	1	3 chunks	+12 lines, -16 lines	0 comments	Download
M	net/spdy/spdy_http_stream.cc	View	1	9 chunks	+34 lines, -46 lines	0 comments	Download
M	net/spdy/spdy_proxy_client_socket.h	View		1 chunk	+4 lines, -6 lines	0 comments	Download
M	net/spdy/spdy_proxy_client_socket.cc	View		2 chunks	+3 lines, -15 lines	0 comments	Download
M	net/spdy/spdy_session.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/spdy_session_spdy3_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_stream.h	View	1 2 3	6 chunks	+18 lines, -35 lines	0 comments	Download
M	net/spdy/spdy_stream.cc	View		11 chunks	+18 lines, -16 lines	0 comments	Download
M	net/spdy/spdy_stream_spdy2_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/spdy_stream_spdy3_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/spdy_stream_test_util.h	View		5 chunks	+13 lines, -23 lines	0 comments	Download
M	net/spdy/spdy_stream_test_util.cc	View		5 chunks	+16 lines, -35 lines	0 comments	Download
M	net/spdy/spdy_websocket_stream.h	View		2 chunks	+8 lines, -9 lines	0 comments	Download
M	net/spdy/spdy_websocket_stream.cc	View		2 chunks	+3 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

LGTM. One small comment nit. Great cleanup. https://codereview.chromium.org/15936003/diff/9002/net/spdy/spdy_proxy_client_socket.cc File net/spdy/spdy_proxy_client_socket.cc (left): https://codereview.chromium.org/15936003/diff/9002/net/spdy/spdy_proxy_client_socket.cc#oldcode453 net/spdy/spdy_proxy_client_socket.cc:453: CHECK(false); YES!!! ...

7 years, 6 months ago (2013-05-28 21:57:13 UTC) #2

akalin

committing soon! https://codereview.chromium.org/15936003/diff/9002/net/spdy/spdy_stream.h File net/spdy/spdy_stream.h (right): https://codereview.chromium.org/15936003/diff/9002/net/spdy/spdy_stream.h#newcode300 net/spdy/spdy_stream.h:300: // OnSendBodyComplete() (if the response hasn't been ...

7 years, 6 months ago (2013-05-28 22:11:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/15936003/16001

7 years, 6 months ago (2013-05-28 22:11:18 UTC) #4

Message was sent while issue was closed.

Change committed as 202703

Expand Messages | Collapse Messages