Issue 15934002: Add IN_DICTIONARY feedback type for spelling service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15934002: Add IN_DICTIONARY feedback type for spelling service (Closed)

Created:
7 years, 7 months ago by please use gerrit instead

Modified:
7 years, 7 months ago

Reviewers:
rpetterson, please use gerrit instead

CC:
chromium-reviews, groby+spellwatch_chromium.org, rpetterson, rouslan+spellwatch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add IN_DICTIONARY feedback type for spelling service This CL adds a feedback type IN_DICTIONARY. Spellcheck will send this feedback when SpellingServiceClient returns a spellcheck result for a word that is in user's custom spellcheck dictionary. Upcoming CLs will address collecting and sending this type of feedback. BUG=170514 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201982

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -0 lines)			Patch
M	chrome/browser/spellchecker/spellcheck_action.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/spellchecker/spellcheck_action.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/spellchecker/spellcheck_action_unittest.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/15934002/1

7 years, 7 months ago (2013-05-23 21:53:37 UTC) #3

Message was sent while issue was closed.

Change committed as 201982

Expand Messages | Collapse Messages