Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 15932003: Make RecreateLayer() order the old layer above the new layer (Closed)

Created:
7 years, 7 months ago by pkotwicz
Modified:
7 years, 7 months ago
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Make RecreateLayer() order the old layer above the new layer. This is required to stack layers with LayerOwners below layers without LayerOwners as per sky@'s suggestion in https://codereview.chromium.org/15114002/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202457

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M ash/system/tray/system_tray_bubble.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M ui/views/view.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pkotwicz
Scott, PTAL
7 years, 7 months ago (2013-05-23 22:09:23 UTC) #1
sky
https://codereview.chromium.org/15932003/diff/2001/ui/views/view.cc File ui/views/view.cc (right): https://codereview.chromium.org/15932003/diff/2001/ui/views/view.cc#newcode542 ui/views/view.cc:542: layer->parent()->StackAbove(layer, View::layer()); I think StackAtTop is going to be ...
7 years, 7 months ago (2013-05-23 22:17:14 UTC) #2
pkotwicz
https://codereview.chromium.org/15932003/diff/2001/ui/views/view.cc File ui/views/view.cc (right): https://codereview.chromium.org/15932003/diff/2001/ui/views/view.cc#newcode542 ui/views/view.cc:542: layer->parent()->StackAbove(layer, View::layer()); You're right
7 years, 7 months ago (2013-05-23 22:22:10 UTC) #3
pkotwicz
I will add a test for view along with https://chromiumcodereview.appspot.com/15114002/
7 years, 7 months ago (2013-05-23 22:22:49 UTC) #4
sky
LGTM
7 years, 7 months ago (2013-05-23 22:25:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/15932003/11001
7 years, 7 months ago (2013-05-26 19:05:05 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118526
7 years, 7 months ago (2013-05-26 21:17:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/15932003/11001
7 years, 7 months ago (2013-05-27 01:42:10 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118564
7 years, 7 months ago (2013-05-27 03:33:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/15932003/33001
7 years, 7 months ago (2013-05-27 16:52:25 UTC) #10
commit-bot: I haz the power
7 years, 7 months ago (2013-05-27 19:00:41 UTC) #11
Message was sent while issue was closed.
Change committed as 202457

Powered by Google App Engine
This is Rietveld 408576698