Move bezel event routing for the shelf into ShelfLayoutManager

Move bezel event routing for the shelf into ShelfLayoutManager

Currently the only functional use of BorderGestureHandler is to funnel gestures
that start on a bezel sensor to the shelf. This CL moves this functionality into
ShelfLayoutManager via a filter class ShelfLayoutManager::BezelEventFilter and
removes BorderGestureHandler.

BUG=224371
TEST=Tested that bezel gestures for the shelf and immersive mode work as
     expected.
     Tested that when rotating the screen gestures on the bezeled sides were
     handled or not handled by the shelf when they should be.
     Added test cases and ran them.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204904

[rharrison, 2013-05-29 20:13:20]

PTAL

[sadrul, 2013-05-31 14:40:38]

Nice! LGTM

https://codereview.chromium.org/15931005/diff/1/ash/shelf/shelf_layout_manage...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/15931005/diff/1/ash/shelf/shelf_layout_manage...
ash/shelf/shelf_layout_manager.cc:150: const gfx::Point& point);
const method

https://codereview.chromium.org/15931005/diff/1/ash/shelf/shelf_layout_manage...
ash/shelf/shelf_layout_manager.cc:213: default:
remove default

[rharrison, 2013-05-31 15:15:46]

Added sky@ for OWNERS

https://codereview.chromium.org/15931005/diff/1/ash/shelf/shelf_layout_manage...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/15931005/diff/1/ash/shelf/shelf_layout_manage...
ash/shelf/shelf_layout_manager.cc:150: const gfx::Point& point);
On 2013/05/31 14:40:38, sadrul wrote:
> const method

Done.

https://codereview.chromium.org/15931005/diff/1/ash/shelf/shelf_layout_manage...
ash/shelf/shelf_layout_manager.cc:213: default:
On 2013/05/31 14:40:38, sadrul wrote:
> remove default

Done.

[sky, 2013-05-31 17:04:50]

https://codereview.chromium.org/15931005/diff/5001/ash/shelf/shelf_layout_man...
File ash/shelf/shelf_layout_manager.h (right):

https://codereview.chromium.org/15931005/diff/5001/ash/shelf/shelf_layout_man...
ash/shelf/shelf_layout_manager.h:321: scoped_ptr<BezelEventFilter>
bezel_event_filter_;
What's the compelling reason to have this owned by the shelf?

[rharrison, 2013-06-05 18:24:04]

https://codereview.chromium.org/15931005/diff/5001/ash/shelf/shelf_layout_man...
File ash/shelf/shelf_layout_manager.h (right):

https://codereview.chromium.org/15931005/diff/5001/ash/shelf/shelf_layout_man...
ash/shelf/shelf_layout_manager.h:321: scoped_ptr<BezelEventFilter>
bezel_event_filter_;
On 2013/05/31 17:04:50, sky wrote:
> What's the compelling reason to have this owned by the shelf?

It ties the filter's lifespan to the shelf, thus the code doesn't have to deal
with 'what if the shelf doesn't exist', since it needs to query the shelf about
its location. Overall I am attempting to localize the code to where it is
needed/used.

[sky, 2013-06-06 15:31:18]

Fair enough, can you move BezelEventFilter into its own file
(shelf_layout_manager.cc is big enough already).

On Wed, Jun 5, 2013 at 11:24 AM,  <rharrison@chromium.org> wrote:
>
>
https://codereview.chromium.org/15931005/diff/5001/ash/shelf/shelf_layout_man...
> File ash/shelf/shelf_layout_manager.h (right):
>
>
https://codereview.chromium.org/15931005/diff/5001/ash/shelf/shelf_layout_man...
> ash/shelf/shelf_layout_manager.h:321: scoped_ptr<BezelEventFilter>
> bezel_event_filter_;
> On 2013/05/31 17:04:50, sky wrote:
>>
>> What's the compelling reason to have this owned by the shelf?
>
>
> It ties the filter's lifespan to the shelf, thus the code doesn't have
> to deal with 'what if the shelf doesn't exist', since it needs to query
> the shelf about its location. Overall I am attempting to localize the
> code to where it is needed/used.
>
> https://codereview.chromium.org/15931005/

[rharrison, 2013-06-06 18:48:15]

Done

[sky, 2013-06-07 04:34:47]

Thanks. LGTM

[commit-bot: I haz the power, 2013-06-07 17:09:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rharrison@chromium.org/15931005/36001

[commit-bot: I haz the power, 2013-06-07 19:58:10]

Change committed as 204904