Issue 15930002: [Android] Force stop test app before launch (start -S)

Issue 15930002: [Android] Force stop test app before launch (start -S) (Closed)

Created:
7 years, 7 months ago by frankf

Modified:
7 years, 7 months ago

Reviewers:
craigdh, frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Force stop test app before launch (start -S) Also: - Wait for launch to complete (start -W) - Move some direct adb calls to android_commands.py NOTRY=True BUG=243074 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201929

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit addressed #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -14 lines)			Patch
	M	build/android/pylib/android_commands.py	View	1	2 chunks	+18 lines, -1 line	0 comments	Download
	M	build/android/pylib/gtest/test_package_apk.py	View		3 chunks	+15 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

craigdh

lgtm with nit. https://codereview.chromium.org/15930002/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/15930002/diff/1/build/android/pylib/android_commands.py#newcode667 build/android/pylib/android_commands.py:667: # The path output only contains ...

7 years, 7 months ago (2013-05-23 21:29:23 UTC) #2

frankf

https://codereview.chromium.org/15930002/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/15930002/diff/1/build/android/pylib/android_commands.py#newcode667 build/android/pylib/android_commands.py:667: # The path output only contains anything if and ...

7 years, 7 months ago (2013-05-23 23:17:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/15930002/8001

7 years, 7 months ago (2013-05-23 23:18:37 UTC) #4

Message was sent while issue was closed.

Change committed as 201929

Expand Messages | Collapse Messages