tools/telemetry/telemetry/page/actions/click_element_unittest.py - Issue 15929007: [Telemetry] Attempt to fix flaky testClickWithSelectorWaitForNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/click_element_unittest.py

Issue 15929007: [Telemetry] Attempt to fix flaky testClickWithSelectorWaitForNavigation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/actions/click_element_unittest.py

diff --git a/tools/telemetry/telemetry/page/actions/click_element_unittest.py b/tools/telemetry/telemetry/page/actions/click_element_unittest.py

index a4b7a5174debc4b3aec3e74b2156df1b3d1ebab0..446ffdc4492539800886dbc0bac1557015a704be 100644

--- a/tools/telemetry/telemetry/page/actions/click_element_unittest.py

+++ b/tools/telemetry/telemetry/page/actions/click_element_unittest.py

@@ -18,7 +18,7 @@ class ClickElementActionTest(tab_test_case.TabTestCase):

self._tab.EvaluateJavaScript('document.location.pathname;'),

'/page_with_link.html')

- data = {'selector': 'a[id="clickme"]', 'wait_for_navigation': True}

+ data = {'selector': 'a[id="clickme"]', 'wait_for_href_change': True}

i = click_element.ClickElementAction(data)

i.RunAction(None, self._tab, None)

« no previous file with comments | « no previous file | no next file » | no next file with comments »