Issue 15929005: [CrOS multi-profiles] Restore user sessions after crash

Issue 15929005: [CrOS multi-profiles] Restore user sessions after crash (Closed)

Created:
7 years, 6 months ago by Nikita (slow)

Modified:
7 years, 6 months ago

Reviewers:
Dmitry Polukhin, satorux1

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Mr4D (OOO till 08-26)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[CrOS multi-profiles] Restore user sessions after crash BUG=180903, 238998, 230464 TEST=Induce browser crash in multi-profile sessions, observe that all user sessions are restored TEST=CrashRestoreSimpleTest, CrashRestoreComplexTest NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202647

Patch Set 1 #

Patch Set 2 : nits #

Total comments: 4

Patch Set 3 : sign out on error #

Patch Set 4 : +test & fixes #

Patch Set 5 : nits #

Total comments: 2

Patch Set 6 : m #

Patch Set 7 : fix test #

Patch Set 8 : nit #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+327 lines, -21 lines)			Patch
M	chrome/browser/chromeos/app_mode/kiosk_app_launcher.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/chromeos/login/crash_restore_browsertest.cc	View	1 2 3 4 5 6 7	1 chunk	+158 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller_browsertest.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.h	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.cc	View	1 2 3	2 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils_browsertest.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/mock_login_utils.h	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_user_manager.h	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/test_login_utils.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/test_login_utils.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager.h	View	1 2 3 4 5 6	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.h	View	1 2 3 4 5 6	8 chunks	+24 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.cc	View	1 2 3 4 5 6	7 chunks	+102 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/profiles/profile_helper.h	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/profiles/profile_helper.cc	View	1 2 3 4 5 6	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/dbus/fake_session_manager_client.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/dbus/fake_session_manager_client.cc	View	1 2 3 4 5 6	3 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 13 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

http://build.chromium.org/p/tryserver.chromium/builders/cros_x86/builds/1942 is actually green (some issues during gclient_revert) linux_chromeos - unrelated but investigating.

7 years, 6 months ago (2013-05-27 13:21:25 UTC) #2

Dmitry Polukhin

https://codereview.chromium.org/15929005/diff/2001/chrome/browser/chromeos/login/user_manager_impl.cc File chrome/browser/chromeos/login/user_manager_impl.cc (right): https://codereview.chromium.org/15929005/diff/2001/chrome/browser/chromeos/login/user_manager_impl.cc#newcode1567 chrome/browser/chromeos/login/user_manager_impl.cc:1567: LOG(ERROR) << "Could not get list of active user ...

7 years, 6 months ago (2013-05-27 13:51:03 UTC) #3

Nikita (slow)

7 years, 6 months ago (2013-05-27 14:22:06 UTC) #4

Nikita (slow)

+satorux@ for chromeos/dbus/fake_session_manager_client.* review Dmitry, please take another look. I've added a test and that ...

7 years, 6 months ago (2013-05-27 17:49:40 UTC) #7

satorux1

chromeos/dbus LGTM https://codereview.chromium.org/15929005/diff/15001/chromeos/dbus/fake_session_manager_client.cc File chromeos/dbus/fake_session_manager_client.cc (right): https://codereview.chromium.org/15929005/diff/15001/chromeos/dbus/fake_session_manager_client.cc#newcode51 chromeos/dbus/fake_session_manager_client.cc:51: DCHECK(user_sessions_.find(user_email) == user_sessions_.end()); matter of taste: this ...

7 years, 6 months ago (2013-05-28 03:39:42 UTC) #8

Dmitry Polukhin

LGTM but please make sure that linux_chromeos tests fail are not related to your change.

7 years, 6 months ago (2013-05-28 06:39:20 UTC) #9

Nikita (slow)

https://codereview.chromium.org/15929005/diff/15001/chromeos/dbus/fake_session_manager_client.cc File chromeos/dbus/fake_session_manager_client.cc (right): https://codereview.chromium.org/15929005/diff/15001/chromeos/dbus/fake_session_manager_client.cc#newcode51 chromeos/dbus/fake_session_manager_client.cc:51: DCHECK(user_sessions_.find(user_email) == user_sessions_.end()); On 2013/05/28 03:39:42, satorux1 wrote: > ...

7 years, 6 months ago (2013-05-28 16:51:17 UTC) #10

Nikita (slow)

cc: skuhne@ The way it works right now is: 1. Add user A to session ...

7 years, 6 months ago (2013-05-28 17:23:24 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/15929005/51002

7 years, 6 months ago (2013-05-28 20:41:19 UTC) #12

Message was sent while issue was closed.

Change committed as 202647

Expand Messages | Collapse Messages