Issue 15927003: Fix MediaPlayerDelegate error handling so it passes the webkitmediasource-errors.html LayoutTest.

Issue 15927003: Fix MediaPlayerDelegate error handling so it passes the webkitmediasource-errors.html LayoutTest. (Closed)

Created:
7 years, 7 months ago by acolwell GONE FROM CHROMIUM

Modified:
7 years, 6 months ago

Reviewers:
commit-bot: I haz the power, qinmin, wolenetz

CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix MediaPlayerDelegate error handling so it passes the webkitmediasource-errors.html LayoutTest. BUG=233420 TEST=http/tests/media/media-source/webkitmediasource-errors.html LayoutTests now passes w/o crashing. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202671

Patch Set 1 #

Patch Set 2 : Fix linux compiler error #

Patch Set 3 : Rebase #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -51 lines)			Patch
M	webkit/media/android/media_source_delegate.cc	View	1 2	1 chunk	+2 lines, -8 lines	0 comments	Download
M	webkit/media/android/webmediaplayer_android.cc	View	1 2	1 chunk	+9 lines, -1 line	0 comments	Download
M	webkit/media/webmediaplayer_impl.cc	View	1 2	2 chunks	+4 lines, -42 lines	0 comments	Download
M	webkit/media/webmediaplayer_util.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	webkit/media/webmediaplayer_util.cc	View	1	1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

wolenetz

Locally, this ps2 doesn't apply cleanly over top of issue 15898002 ps2 (currently in CQ). ...

7 years, 7 months ago (2013-05-24 00:54:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/15927003/13001

7 years, 6 months ago (2013-05-28 20:11:39 UTC) #4

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 6 months ago (2013-05-28 20:46:44 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/15927003/13001

7 years, 6 months ago (2013-05-28 20:51:19 UTC) #6

Message was sent while issue was closed.

Change committed as 202671

Expand Messages | Collapse Messages