Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Unified Diff: content/browser/renderer_host/render_widget_host_delegate.h

Issue 1592573002: Fixing WebViewVisibilityTests for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added Tests and TODO Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_delegate.h
diff --git a/content/browser/renderer_host/render_widget_host_delegate.h b/content/browser/renderer_host/render_widget_host_delegate.h
index f7fbb0e362247ff0b078db858a933b09e2e394d1..3048515cc859a2e6f5121d0ef8e1691e35468c31 100644
--- a/content/browser/renderer_host/render_widget_host_delegate.h
+++ b/content/browser/renderer_host/render_widget_host_delegate.h
@@ -180,6 +180,10 @@ class CONTENT_EXPORT RenderWidgetHostDelegate {
virtual void ForwardCompositorProto(RenderWidgetHostImpl* render_widget_host,
const std::vector<uint8_t>& proto) {}
+ // Called when the visibility of the widget has changed in the parent
+ // renderer process.
no sievers 2016/01/26 20:33:07 Can you make the comment and function name more sp
EhsanK 2016/01/27 16:03:22 Done. I am explicitly naming the function based on
+ virtual void ForwardVisibilityChange(bool visible) {}
+
protected:
virtual ~RenderWidgetHostDelegate() {}
};

Powered by Google App Engine
This is Rietveld 408576698