Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: components/guest_view/browser/guest_view_base.cc

Issue 1592573002: Fixing WebViewVisibilityTests for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: BrowserPluginGuest does not Change Visibility of OOPIF-<webview> Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/browser/guest_view_base.cc
diff --git a/components/guest_view/browser/guest_view_base.cc b/components/guest_view/browser/guest_view_base.cc
index 6b23d13f5a1ee6b1d19599ff8cda64605bbd900a..d4209695bcc7b56511f1a65bcf0780689b94dccf 100644
--- a/components/guest_view/browser/guest_view_base.cc
+++ b/components/guest_view/browser/guest_view_base.cc
@@ -601,13 +601,6 @@ void GuestViewBase::DidNavigateMainFrame(
const content::FrameNavigateParams& params) {
if (attached() && ZoomPropagatesFromEmbedderToGuest())
SetGuestZoomLevelToMatchEmbedder();
-
- // TODO(lazyboy): This breaks guest visibility in --site-per-process because
- // we do not take the widget's visibility into account. We need to also
- // stay hidden during "visibility:none" state.
- if (content::BrowserPluginGuestMode::UseCrossProcessFramesForGuests()) {
- web_contents()->WasShown();
- }
}
void GuestViewBase::ActivateContents(WebContents* web_contents) {
« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698