Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 15925005: [Quota][Clean up] Drop non-informative StorageType parameter on GetOriginsForType callback (Closed)

Created:
7 years, 7 months ago by tzik
Modified:
7 years, 6 months ago
Reviewers:
michaeln, kinuko
CC:
chromium-reviews, tzik+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch
Visibility:
Public.

Description

[Quota][Clean up] Drop non-informative StorageType parameter on GetOriginsForType callback The caller of GetOriginsForType should know the StorageType, so this parameter will not add any information to the callback. Historically this was useful when we'd used old callbacks. BUG=220029 TEST=should not break existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202805

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -64 lines) Patch
M content/browser/indexed_db/indexed_db_quota_client.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M content/browser/indexed_db/indexed_db_quota_client_unittest.cc View 4 chunks +1 line, -6 lines 0 comments Download
M webkit/appcache/appcache_quota_client.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/appcache/appcache_quota_client_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M webkit/browser/database/database_quota_client.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M webkit/browser/database/database_quota_client_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M webkit/browser/fileapi/file_system_quota_client.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M webkit/browser/fileapi/file_system_quota_client_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M webkit/quota/mock_storage_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/quota/quota_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/quota/quota_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/quota/usage_tracker.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M webkit/quota/usage_tracker.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M webkit/quota/usage_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tzik
PTAL, Kinuko-san. I'd like to drop a unused parameter as a clean up. Michael: Could ...
7 years, 7 months ago (2013-05-27 06:32:03 UTC) #1
kinuko
lgtm
7 years, 7 months ago (2013-05-27 06:51:18 UTC) #2
michaeln
lgtm2
7 years, 6 months ago (2013-05-28 19:03:41 UTC) #3
tzik
On 2013/05/28 19:03:41, michaeln wrote: > lgtm2 Thanks!
7 years, 6 months ago (2013-05-29 02:32:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/15925005/7001
7 years, 6 months ago (2013-05-29 02:32:32 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 07:54:37 UTC) #6
Message was sent while issue was closed.
Change committed as 202805

Powered by Google App Engine
This is Rietveld 408576698