Issue 15922004: Rename Widget::CalculateOffsetToAncestorWithLayer() to Widget::GetLayer()

Issue 15922004: Rename Widget::CalculateOffsetToAncestorWithLayer() to Widget::GetLayer() (Closed)

Created:
7 years, 7 months ago by pkotwicz

Modified:
7 years, 7 months ago

Reviewers:
pkotwicz, sky, commit-bot: I haz the power

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Renames Rename CalculateOffsetToAncestorWithLayer() to GetLayer(). Refactors View::ReorderLayers() so that it does not call into the widget anymore. Bug=237650 Test=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202333

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -79 lines)			Patch
M	ui/views/view.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	ui/views/view.cc	View	3 chunks	+21 lines, -26 lines	0 comments	Download
M	ui/views/view_unittest.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_native_widget_aura.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_native_widget_aura.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	ui/views/widget/native_widget_private.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	ui/views/widget/native_widget_win.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/views/widget/native_widget_win.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	ui/views/widget/root_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/root_view.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	ui/views/widget/widget.h	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	ui/views/widget/widget.cc	View	1 chunk	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/15922004/1

7 years, 7 months ago (2013-05-24 20:43:06 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118266

7 years, 7 months ago (2013-05-24 22:54:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/15922004/1

7 years, 7 months ago (2013-05-24 23:30:05 UTC) #5

Message was sent while issue was closed.

Change committed as 202333

Expand Messages | Collapse Messages