net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java - Issue 159173002: Refactor ActivityStatus to not store current activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java

Issue 159173002: Refactor ActivityStatus to not store current activity (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed Comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/ssl_client_certificate_request.cc ('K') | « net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java ('k') | net/disk_cache/simple/simple_index.h » ('j') | net/disk_cache/simple/simple_index.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java

diff --git a/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java b/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java

index 01c05b8fd677452892f62539b0112b228afe6ac1..b95c8ad29db8847702a7491d4635eafb8455e6fe 100644

--- a/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java

+++ b/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java

@@ -163,14 +163,14 @@ public class NetworkChangeNotifierTest extends InstrumentationTestCase {

observer.resetHasReceivedNotification();

// Pretend we got moved to the background.

- receiver.onActivityStateChange(ActivityStatus.PAUSED);

+ receiver.onApplicationStateChange(ActivityStatus.APP_PAUSED);

// Change the state.

connectivityDelegate.setActiveNetworkExists(true);

connectivityDelegate.setNetworkType(NetworkChangeNotifier.CONNECTION_WIFI);

// The NetworkChangeNotifierAutoDetect doesn't receive any notification while we are in the

// background, but when we get back to the foreground the state changed should be detected

// and a notification sent.

- receiver.onActivityStateChange(ActivityStatus.RESUMED);

+ receiver.onApplicationStateChange(ActivityStatus.APP_RUNNING);

assertTrue(observer.hasReceivedNotification());

}