base/android/application_state_list.h - Issue 159173002: Refactor ActivityStatus to not store current activity

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/android/application_state_list.h

Issue 159173002: Refactor ActivityStatus to not store current activity (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed Comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // This file intentionally does not have header guards, it's included

	6 // inside a macro to generate enum values.

	7

	8 #ifndef DEFINE_APPLICATION_STATE

	9 #error "DEFINE_APPLICATION_STATE should be defined before including this file"

	10 #endif

	11 DEFINE_APPLICATION_STATE(RUNNING, 1)
	bulach 2014/02/13 11:17:48 see below, perhaps it'd be better to have somethin see below, perhaps it'd be better to have something like: HAS_ANY_RUNNING_ACTIVITIES HAS_ONLY_PAUSED_ACTIVITIES HAS_ONLY_STOPPED_ACTIVITIES DESTROYED to be more explicit this is not an application state per se, but rather a derivation of the underlying activities? wdyt? David Trainor- moved to gerrit 2014/02/14 19:13:36 Done. Show quoted text On 2014/02/13 11:17:48, bulach wrote: > see below, perhaps it'd be better to have something like: > HAS_ANY_RUNNING_ACTIVITIES > HAS_ONLY_PAUSED_ACTIVITIES > HAS_ONLY_STOPPED_ACTIVITIES > DESTROYED > > to be more explicit this is not an application state per se, but rather a > derivation of the underlying activities? wdyt? Done.
	12 DEFINE_APPLICATION_STATE(PAUSED, 2)

	13 DEFINE_APPLICATION_STATE(STOPPED, 3)

	14 DEFINE_APPLICATION_STATE(DESTROYED, 3)

OLD	NEW