Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: base/android/activity_status.cc

Issue 159173002: Refactor ActivityStatus to not store current activity (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/activity_status.h" 5 #include "base/android/activity_status.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 8
9 #include "base/memory/singleton.h" 9 #include "base/memory/singleton.h"
10 #include "jni/ActivityStatus_jni.h" 10 #include "jni/ActivityStatus_jni.h"
11 11
12 namespace base { 12 namespace base {
13 namespace android { 13 namespace android {
14 14
15 ActivityStatus::Listener::Listener( 15 ActivityStatus::Listener::Listener(
16 const ActivityStatus::StateChangeCallback& callback) 16 const ActivityStatus::ApplicationStateChangeCallback& callback)
17 : callback_(callback) { 17 : callback_(callback) {
18 ActivityStatus::GetInstance()->RegisterListener(this); 18 ActivityStatus::GetInstance()->RegisterListener(this);
19 } 19 }
20 20
21 ActivityStatus::Listener::~Listener() { 21 ActivityStatus::Listener::~Listener() {
22 ActivityStatus::GetInstance()->UnregisterListener(this); 22 ActivityStatus::GetInstance()->UnregisterListener(this);
23 } 23 }
24 24
25 void ActivityStatus::Listener::Notify(ActivityState state) { 25 void ActivityStatus::Listener::Notify(ApplicationState state) {
26 callback_.Run(state); 26 callback_.Run(state);
27 } 27 }
28 28
29 // static 29 // static
30 ActivityStatus* ActivityStatus::GetInstance() { 30 ActivityStatus* ActivityStatus::GetInstance() {
31 return Singleton<ActivityStatus, 31 return Singleton<ActivityStatus,
32 LeakySingletonTraits<ActivityStatus> >::get(); 32 LeakySingletonTraits<ActivityStatus> >::get();
33 } 33 }
34 34
35 static void OnActivityStateChange(JNIEnv* env, jclass clazz, int new_state) { 35 static void OnApplicationStateChange(JNIEnv* env,
36 jclass clazz,
37 jint new_state) {
36 ActivityStatus* activity_status = ActivityStatus::GetInstance(); 38 ActivityStatus* activity_status = ActivityStatus::GetInstance();
37 ActivityState activity_state = static_cast<ActivityState>(new_state); 39 ApplicationState application_state = static_cast<ApplicationState>(new_state);
38 activity_status->OnActivityStateChange(activity_state); 40 activity_status->OnApplicationStateChange(application_state);
39 } 41 }
40 42
41 bool ActivityStatus::RegisterBindings(JNIEnv* env) { 43 bool ActivityStatus::RegisterBindings(JNIEnv* env) {
42 return RegisterNativesImpl(env); 44 return RegisterNativesImpl(env);
43 } 45 }
44 46
45 ActivityStatus::ActivityStatus() 47 ActivityStatus::ActivityStatus()
46 : observers_(new ObserverListThreadSafe<Listener>()) { 48 : observers_(new ObserverListThreadSafe<Listener>()) {
47 Java_ActivityStatus_registerThreadSafeNativeStateListener( 49 Java_ActivityStatus_registerThreadSafeNativeApplicationStateListener(
48 base::android::AttachCurrentThread()); 50 base::android::AttachCurrentThread());
49 } 51 }
50 52
51 ActivityStatus::~ActivityStatus() {} 53 ActivityStatus::~ActivityStatus() {}
52 54
53 void ActivityStatus::RegisterListener(Listener* listener) { 55 void ActivityStatus::RegisterListener(Listener* listener) {
54 observers_->AddObserver(listener); 56 observers_->AddObserver(listener);
55 } 57 }
56 58
57 void ActivityStatus::UnregisterListener(Listener* listener) { 59 void ActivityStatus::UnregisterListener(Listener* listener) {
58 observers_->RemoveObserver(listener); 60 observers_->RemoveObserver(listener);
59 } 61 }
60 62
61 void ActivityStatus::OnActivityStateChange(ActivityState new_state) { 63 void ActivityStatus::OnApplicationStateChange(ApplicationState state) {
62 observers_->Notify(&ActivityStatus::Listener::Notify, new_state); 64 observers_->Notify(&ActivityStatus::Listener::Notify, state);
63 } 65 }
64 66
65 } // namespace android 67 } // namespace android
66 } // namespace base 68 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698