Fix and enable mojo:media_pipeline_integration_apptests.

Fix and enable mojo:media_pipeline_integration_apptests.

Currently the mojo implementation doesn't fully support EME nor
clockless playback, so those tests are disabled for mojo.

BUG=501417
TEST=new tests pass

Committed: https://crrev.com/135d61ec919d5c3bbd2b0c7db2a52c9f8bd5c82e
Cr-Commit-Position: refs/heads/master@{#371840}

[jrummell, 2016-01-15 20:22:28]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org

[jrummell, 2016-01-15 20:22:28]

PTAL.

[xhwang, 2016-01-20 05:33:35]

Thanks! Just one comment :)

https://chromiumcodereview.appspot.com/1591103002/diff/1/media/test/pipeline_...
File media/test/pipeline_integration_test.cc (right):

https://chromiumcodereview.appspot.com/1591103002/diff/1/media/test/pipeline_...
media/test/pipeline_integration_test.cc:837: #endif  //
defined(DISABLE_CLOCKLESS_TESTS)
Is it possible to wrap these defines in a macro, something like:

https://code.google.com/p/chromium/codesearch#chromium/src/ui/aura/window_eve...

[jrummell, 2016-01-21 01:30:26]

Updated.

https://codereview.chromium.org/1591103002/diff/1/media/test/pipeline_integra...
File media/test/pipeline_integration_test.cc (right):

https://codereview.chromium.org/1591103002/diff/1/media/test/pipeline_integra...
media/test/pipeline_integration_test.cc:837: #endif  //
defined(DISABLE_CLOCKLESS_TESTS)
On 2016/01/20 05:33:35, xhwang wrote:
> Is it possible to wrap these defines in a macro, something like:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/aura/window_eve...

Done.

[xhwang, 2016-01-21 05:38:39]

LGTM!

[jrummell, 2016-01-21 19:53:43]

jrummell@chromium.org changed reviewers:
+ sky@chromium.org

[jrummell, 2016-01-21 19:53:43]

+sky@ for OWNERS review of mojo/tools/data/apptests

[sky, 2016-01-21 20:31:39]

https://codereview.chromium.org/1591103002/diff/20001/mojo/tools/data/apptests
File mojo/tools/data/apptests (right):

https://codereview.chromium.org/1591103002/diff/20001/mojo/tools/data/apptest...
mojo/tools/data/apptests:91: 'test': 'mojo:media_pipeline_integration_apptests',
Is this depended on by the target the builders look for to determine if
mojo_apptests should run?

[jrummell, 2016-01-26 19:47:41]

Comments only.

https://codereview.chromium.org/1591103002/diff/20001/mojo/tools/data/apptests
File mojo/tools/data/apptests (right):

https://codereview.chromium.org/1591103002/diff/20001/mojo/tools/data/apptest...
mojo/tools/data/apptests:91: 'test': 'mojo:media_pipeline_integration_apptests',
On 2016/01/21 20:31:39, sky wrote:
> Is this depended on by the target the builders look for to determine if
> mojo_apptests should run?

I think so, assuming media_apptests was done properly. The dependency has
previously been checked into media/mojo/services/BUILD.gn (in group("tests"),
the first file in this CL, lines 258-270).

I also checked, and the tests did run on the trybots (for
linux_chromium_rel_ng).

[sky, 2016-01-26 23:27:23]

https://codereview.chromium.org/1591103002/diff/20001/mojo/tools/data/apptests
File mojo/tools/data/apptests (right):

https://codereview.chromium.org/1591103002/diff/20001/mojo/tools/data/apptest...
mojo/tools/data/apptests:91: 'test': 'mojo:media_pipeline_integration_apptests',
On 2016/01/26 19:47:41, jrummell wrote:
> On 2016/01/21 20:31:39, sky wrote:
> > Is this depended on by the target the builders look for to determine if
> > mojo_apptests should run?
> 
> I think so, assuming media_apptests was done properly. The dependency has
> previously been checked into media/mojo/services/BUILD.gn (in group("tests"),
> the first file in this CL, lines 258-270).
> 
> I also checked, and the tests did run on the trybots (for
> linux_chromium_rel_ng).

I think it safer to update the mojo_apptests in src/BUILD.gn (I recently added
it, there is a comment in this file to that effect if you sync to tip of tree).

[jrummell, 2016-01-27 00:50:47]

Patchset #3 (id:40001) has been deleted

[jrummell, 2016-01-27 00:55:27]

Updated to get the latest apptest changes.

https://codereview.chromium.org/1591103002/diff/20001/mojo/tools/data/apptests
File mojo/tools/data/apptests (right):

https://codereview.chromium.org/1591103002/diff/20001/mojo/tools/data/apptest...
mojo/tools/data/apptests:91: 'test': 'mojo:media_pipeline_integration_apptests',
On 2016/01/26 23:27:23, sky wrote:
> On 2016/01/26 19:47:41, jrummell wrote:
> > On 2016/01/21 20:31:39, sky wrote:
> > > Is this depended on by the target the builders look for to determine if
> > > mojo_apptests should run?
> > 
> > I think so, assuming media_apptests was done properly. The dependency has
> > previously been checked into media/mojo/services/BUILD.gn (in
group("tests"),
> > the first file in this CL, lines 258-270).
> > 
> > I also checked, and the tests did run on the trybots (for
> > linux_chromium_rel_ng).
> 
> I think it safer to update the mojo_apptests in src/BUILD.gn (I recently added
> it, there is a comment in this file to that effect if you sync to tip of
tree).

Done.

[sky, 2016-01-27 03:09:16]

LGTM

[sky, 2016-01-27 03:09:39]

sky@chromium.org changed reviewers:
+ dpranke@chromium.org

[sky, 2016-01-27 03:09:40]

+dpranke for /BUILD.gn

[Dirk Pranke, 2016-01-27 04:01:15]

lgtm

[jrummell, 2016-01-27 18:14:12]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-01-27 18:14:13]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1591103002/#ps60001
(title: "Add deps in src/BUILD.gn (plus rebase)")

[commit-bot: I haz the power, 2016-01-27 18:15:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1591103002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1591103002/60001

[commit-bot: I haz the power, 2016-01-27 19:36:28]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-01-27 19:37:36]

Description was changed from

==========
Fix and enable mojo:media_pipeline_integration_apptests.

Currently the mojo implementation doesn't fully support EME nor
clockless playback, so those tests are disabled for mojo.

BUG=501417
TEST=new tests pass
==========

to

==========
Fix and enable mojo:media_pipeline_integration_apptests.

Currently the mojo implementation doesn't fully support EME nor
clockless playback, so those tests are disabled for mojo.

BUG=501417
TEST=new tests pass

Committed: https://crrev.com/135d61ec919d5c3bbd2b0c7db2a52c9f8bd5c82e
Cr-Commit-Position: refs/heads/master@{#371840}
==========

[commit-bot: I haz the power, 2016-01-27 19:37:37]

Patchset 3 (id:??) landed as
https://crrev.com/135d61ec919d5c3bbd2b0c7db2a52c9f8bd5c82e
Cr-Commit-Position: refs/heads/master@{#371840}