Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 15911004: Fix test for libudev1 (Closed)

Created:
7 years, 7 months ago by Peter Mayo
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix test for libudev1 The test for libudev1/libudev0 fails when an sdk has installed a dependency on libudev1, which will go away on recompile, on a system with only libudev0. The dependency created an empty virtual package that passes the "show" test, but cannot be installed. BUG=243398 TEST=local Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-build-deps.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Mayo
This fixes my use of the simplechrome workflow for ChromiumOS.
7 years, 7 months ago (2013-05-23 20:42:13 UTC) #1
Paweł Hajdan Jr.
LGTM
7 years, 7 months ago (2013-05-23 21:25:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/15911004/1
7 years, 7 months ago (2013-05-23 22:35:01 UTC) #3
haltonhuo
On 2013/05/23 20:42:13, Peter Mayo wrote: > This fixes my use of the simplechrome workflow ...
7 years, 7 months ago (2013-05-24 01:49:57 UTC) #4
Peter Mayo
On 2013/05/24 01:49:57, haltonhuo wrote: > On 2013/05/23 20:42:13, Peter Mayo wrote: > > This ...
7 years, 7 months ago (2013-05-24 02:15:16 UTC) #5
haltonhuo
On 2013/05/24 02:15:16, Peter Mayo wrote: > I didn't run into a problem with them ...
7 years, 7 months ago (2013-05-24 02:35:54 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 07:59:52 UTC) #7
Message was sent while issue was closed.
Change committed as 202021

Powered by Google App Engine
This is Rietveld 408576698