chrome/renderer/searchbox/searchbox.cc - Issue 15907006: Rip out browser-side RID caching for most visited items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/searchbox/searchbox.cc

Issue 15907006: Rip out browser-side RID caching for most visited items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: '' Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/searchbox/searchbox.cc

diff --git a/chrome/renderer/searchbox/searchbox.cc b/chrome/renderer/searchbox/searchbox.cc

index a62cabe3bf6558accad14e76cc863a87f8741e46..6ea57928217d2e83db74fa988cdc089b969a0507 100644

--- a/chrome/renderer/searchbox/searchbox.cc

+++ b/chrome/renderer/searchbox/searchbox.cc

@@ -409,9 +409,8 @@ void SearchBox::SetQuery(const string16& query, bool verbatim) {

}

void SearchBox::OnMostVisitedChanged(

- const std::vector<InstantMostVisitedItemIDPair>& items) {

- most_visited_items_cache_.AddItemsWithRestrictedID(items);

+ const std::vector<InstantMostVisitedItem>& items) {

+ most_visited_items_cache_.AddItems(items);

if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {

extensions_v8::SearchBoxExtension::DispatchMostVisitedChanged(

render_view()->GetWebView()->mainFrame());