Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Side by Side Diff: chrome/renderer/searchbox/searchbox.cc

Issue 15907006: Rip out browser-side RID caching for most visited items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: '' Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/searchbox/searchbox.h" 5 #include "chrome/renderer/searchbox/searchbox.h"
6 6
7 #include "base/string_number_conversions.h" 7 #include "base/string_number_conversions.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/common/chrome_switches.h" 9 #include "chrome/common/chrome_switches.h"
10 #include "chrome/common/omnibox_focus_state.h" 10 #include "chrome/common/omnibox_focus_state.h"
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 // changes. 402 // changes.
403 } 403 }
404 404
405 void SearchBox::SetQuery(const string16& query, bool verbatim) { 405 void SearchBox::SetQuery(const string16& query, bool verbatim) {
406 query_ = query; 406 query_ = query;
407 verbatim_ = verbatim; 407 verbatim_ = verbatim;
408 query_is_restricted_ = false; 408 query_is_restricted_ = false;
409 } 409 }
410 410
411 void SearchBox::OnMostVisitedChanged( 411 void SearchBox::OnMostVisitedChanged(
412 const std::vector<InstantMostVisitedItemIDPair>& items) { 412 const std::vector<InstantMostVisitedItem>& items) {
413 most_visited_items_cache_.AddItemsWithRestrictedID(items); 413 most_visited_items_cache_.AddItems(items);
414
415 if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) { 414 if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
416 extensions_v8::SearchBoxExtension::DispatchMostVisitedChanged( 415 extensions_v8::SearchBoxExtension::DispatchMostVisitedChanged(
417 render_view()->GetWebView()->mainFrame()); 416 render_view()->GetWebView()->mainFrame());
418 } 417 }
419 } 418 }
420 419
421 void SearchBox::GetMostVisitedItems( 420 void SearchBox::GetMostVisitedItems(
422 std::vector<InstantMostVisitedItemIDPair>* items) const { 421 std::vector<InstantMostVisitedItemIDPair>* items) const {
423 return most_visited_items_cache_.GetCurrentItems(items); 422 return most_visited_items_cache_.GetCurrentItems(items);
424 } 423 }
425 424
426 bool SearchBox::GetMostVisitedItemWithID( 425 bool SearchBox::GetMostVisitedItemWithID(
427 InstantRestrictedID most_visited_item_id, 426 InstantRestrictedID most_visited_item_id,
428 InstantMostVisitedItem* item) const { 427 InstantMostVisitedItem* item) const {
429 return most_visited_items_cache_.GetItemWithRestrictedID(most_visited_item_id, 428 return most_visited_items_cache_.GetItemWithRestrictedID(most_visited_item_id,
430 item); 429 item);
431 } 430 }
432 431
433 GURL SearchBox::GetURLForMostVisitedItem(InstantRestrictedID item_id) const { 432 GURL SearchBox::GetURLForMostVisitedItem(InstantRestrictedID item_id) const {
434 InstantMostVisitedItem item; 433 InstantMostVisitedItem item;
435 return GetMostVisitedItemWithID(item_id, &item) ? item.url : GURL(); 434 return GetMostVisitedItemWithID(item_id, &item) ? item.url : GURL();
436 } 435 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698