Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 15901002: Implement Encoding API (Closed)

Created:
7 years, 7 months ago by jsbell
Modified:
7 years, 4 months ago
CC:
blink-reviews, eae+blinkwatch, cshu
Visibility:
Public.

Description

Implement Encoding API Initial implementation, behind the experimental features flag. Tests are derived from my JS impl: code.google.com/p/stringencoding/ Many of the tests have FAIL results, due to a mix of: * Mismatch between canonical encoding names * Unsupported encodings from the spec * Extra encodings (e.g "us-ascii") that are mapped differently in the spec * Issues with streaming encode/decode (e.g. split UTF-16 code units) * Possible encoder differences In other words, there's still a lot of work to do. BUG=243354 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155379

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Remove bloatedCharacters() call #

Patch Set 4 : Rebased #

Patch Set 5 : Rebaseline webexposed global constructor tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1346 lines, -76 lines) Patch
A LayoutTests/fast/encoding/api/ascii-supersets.html View 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/ascii-supersets-expected.txt View 1 chunk +124 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/basics.html View 1 chunk +61 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/basics-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/byte-order-marks.html View 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/byte-order-marks-expected.txt View 1 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/encoding-names.html View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/encoding-names-expected.txt View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/end-of-file.html View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/end-of-file-expected.txt View 1 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/fatal-flag.html View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/fatal-flag-expected.txt View 1 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/legacy-encode.html View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/legacy-encode-expected.txt View 1 chunk +89 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/resources/shared.js View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/streaming-decode.html View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/streaming-decode-expected.txt View 1 chunk +321 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/surrogate-pairs.html View 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/surrogate-pairs-expected.txt View 1 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/utf-round-trip.html View 1 chunk +97 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/utf-round-trip-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-dedicated-worker-expected.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-shared-worker-expected.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + Source/modules/encoding/TextDecoder.h View 1 2 3 1 chunk +22 lines, -23 lines 0 comments Download
A + Source/modules/encoding/TextDecoder.cpp View 1 2 3 1 chunk +45 lines, -28 lines 0 comments Download
A + Source/modules/encoding/TextDecoder.idl View 1 4 1 chunk +7 lines, -4 lines 0 comments Download
A + Source/modules/encoding/TextEncoder.h View 1 1 chunk +22 lines, -14 lines 0 comments Download
A Source/modules/encoding/TextEncoder.cpp View 1 2 1 chunk +98 lines, -0 lines 0 comments Download
A + Source/modules/encoding/TextEncoder.idl View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jsbell
Might be worth landing this now just so it doesn't get moldy again, but otherwise ...
7 years, 5 months ago (2013-07-16 22:05:22 UTC) #1
Ken Russell (switch to Gerrit)
LGTM. The tests look great, and thorough. A plan is needed to finish the implementation ...
7 years, 5 months ago (2013-07-18 19:32:42 UTC) #2
Ken Russell (switch to Gerrit)
Is there any reason not to commit this? If not, let's do it!
7 years, 4 months ago (2013-07-30 22:31:55 UTC) #3
jsbell
On 2013/07/30 22:31:55, Ken Russell wrote: > Is there any reason not to commit this? ...
7 years, 4 months ago (2013-07-30 22:43:04 UTC) #4
dglazkov
lgtm
7 years, 4 months ago (2013-07-31 20:06:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/15901002/11001
7 years, 4 months ago (2013-07-31 20:13:33 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=677
7 years, 4 months ago (2013-07-31 21:49:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/15901002/11001
7 years, 4 months ago (2013-07-31 22:09:53 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=698
7 years, 4 months ago (2013-08-01 00:32:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/15901002/36001
7 years, 4 months ago (2013-08-01 20:49:38 UTC) #10
commit-bot: I haz the power
7 years, 4 months ago (2013-08-02 04:31:32 UTC) #11
Message was sent while issue was closed.
Change committed as 155379

Powered by Google App Engine
This is Rietveld 408576698