Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Issue 15899015: Add CheckPortalList manager property to NetworkStateHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: force manager property update in shill manager client stub implementation Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/wizard_controller.cc ('k') | chromeos/dbus/shill_manager_client_stub.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/wizard_controller_browsertest.cc
diff --git a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
index 361523c2c260e07cd6b3cc6bfe5d1c396d53070f..5896d5260af01593e891237f92427290e26b86f4 100644
--- a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
+++ b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
@@ -7,8 +7,6 @@
#include "base/utf_string_conversions.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/browser_shutdown.h"
-#include "chrome/browser/chromeos/cros/cros_library.h"
-#include "chrome/browser/chromeos/cros/network_library.h"
#include "chrome/browser/chromeos/login/enrollment/enrollment_screen.h"
#include "chrome/browser/chromeos/login/enrollment/mock_enrollment_screen.h"
#include "chrome/browser/chromeos/login/existing_user_controller.h"
@@ -31,6 +29,7 @@
#include "chrome/test/base/ui_test_utils.h"
#include "chromeos/chromeos_switches.h"
#include "chromeos/chromeos_test_utils.h"
+#include "chromeos/network/network_state_handler.h"
#include "grit/generated_resources.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -122,7 +121,7 @@ class WizardControllerFlowTest : public WizardControllerTest {
WizardController::default_controller()->is_official_build_ = true;
// Clear portal list (as it is by default in OOBE).
- CrosLibrary::Get()->GetNetworkLibrary()->SetCheckPortalList("");
+ NetworkHandler::Get()->network_state_handler()->SetCheckPortalList("");
// Set up the mocks for all screens.
MOCK(mock_network_screen_, network_screen_,
@@ -179,8 +178,9 @@ IN_PROC_BROWSER_TEST_F(WizardControllerFlowTest, ControlFlowMain) {
OnExit(ScreenObserver::UPDATE_INSTALLED);
EXPECT_FALSE(ExistingUserController::current_controller() == NULL);
- EXPECT_EQ("ethernet,wifi,cellular",
- CrosLibrary::Get()->GetNetworkLibrary()->GetCheckPortalList());
+ EXPECT_EQ(
+ "ethernet,wifi,cellular",
+ NetworkHandler::Get()->network_state_handler()->check_portal_list());
}
IN_PROC_BROWSER_TEST_F(WizardControllerFlowTest, ControlFlowErrorUpdate) {
@@ -235,12 +235,14 @@ IN_PROC_BROWSER_TEST_F(WizardControllerFlowTest, ControlFlowSkipUpdateEnroll) {
EXPECT_CALL(*mock_enrollment_screen_, Show()).Times(1);
EXPECT_CALL(*mock_enrollment_screen_, Hide()).Times(0);
OnExit(ScreenObserver::EULA_ACCEPTED);
+ content::RunAllPendingInMessageLoop();
EXPECT_EQ(WizardController::default_controller()->GetEnrollmentScreen(),
WizardController::default_controller()->current_screen());
EXPECT_TRUE(ExistingUserController::current_controller() == NULL);
- EXPECT_EQ("ethernet,wifi,cellular",
- CrosLibrary::Get()->GetNetworkLibrary()->GetCheckPortalList());
+ EXPECT_EQ(
+ "ethernet,wifi,cellular",
+ NetworkHandler::Get()->network_state_handler()->check_portal_list());
}
IN_PROC_BROWSER_TEST_F(WizardControllerFlowTest, ControlFlowEulaDeclined) {
« no previous file with comments | « chrome/browser/chromeos/login/wizard_controller.cc ('k') | chromeos/dbus/shill_manager_client_stub.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698