Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 15898003: Remove touch_drag_drop web preference. It was added in r184242 for tests to be (Closed)

Created:
7 years, 7 months ago by varunjain
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Remove touch_drag_drop web preference. It was added in r184242 for tests to be able to override it. But there is already functionality in internals.settings to to that. BUG=231643 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/common/webkit_test_helpers.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
varunjain
7 years, 7 months ago (2013-05-23 22:22:07 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 7 months ago (2013-05-24 06:45:44 UTC) #2
Charlie Reis
Rubber stamp LGTM
7 years, 7 months ago (2013-05-24 16:05:29 UTC) #3
michaeln
Rubber stamp LGTM2
7 years, 6 months ago (2013-05-29 17:43:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/15898003/1
7 years, 6 months ago (2013-05-29 18:06:00 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 20:45:41 UTC) #6
Message was sent while issue was closed.
Change committed as 202958

Powered by Google App Engine
This is Rietveld 408576698