Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: webkit/media/android/webmediaplayer_android.h

Issue 15898002: Fix various MediaSource related crashes on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make Destroy() public and remove friend decl to make compiler happy Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/media/android/media_source_delegate.cc ('k') | webkit/media/android/webmediaplayer_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/android/webmediaplayer_android.h
diff --git a/webkit/media/android/webmediaplayer_android.h b/webkit/media/android/webmediaplayer_android.h
index c492910e9422ef6bbb4d75d529864e270a2d1952..f3440866a9abb0fa8c16861b26af473e8e7156e1 100644
--- a/webkit/media/android/webmediaplayer_android.h
+++ b/webkit/media/android/webmediaplayer_android.h
@@ -19,6 +19,7 @@
#include "third_party/WebKit/Source/Platform/chromium/public/WebURL.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebMediaPlayer.h"
#include "ui/gfx/rect_f.h"
+#include "webkit/media/android/media_source_delegate.h"
#include "webkit/media/android/stream_texture_factory_android.h"
namespace media {
@@ -34,8 +35,6 @@ class WebLayerImpl;
}
namespace webkit_media {
-
-class MediaSourceDelegate;
class WebMediaPlayerManagerAndroid;
class WebMediaPlayerProxyAndroid;
@@ -304,7 +303,8 @@ class WebMediaPlayerAndroid
gfx::RectF last_computed_rect_;
#endif
- scoped_ptr<MediaSourceDelegate> media_source_delegate_;
+ scoped_ptr<MediaSourceDelegate,
+ MediaSourceDelegate::Destroyer> media_source_delegate_;
// Proxy object that delegates method calls on Render Thread.
// This object is created on the Render Thread and is only called in the
« no previous file with comments | « webkit/media/android/media_source_delegate.cc ('k') | webkit/media/android/webmediaplayer_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698