Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 15898002: Fix various MediaSource related crashes on Android. (Closed)

Created:
7 years, 7 months ago by acolwell GONE FROM CHROMIUM
Modified:
7 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix various MediaSource related crashes on Android. This change fixes several issues that were causing crashes. - MediaPlayerHostMsg_DemuxerReady_Params was not initializing the xxx_codec member variables so audio-only or video-only content would randomly be flagged as A/V content with a random codec ID. - ChunkDemuxer::Stop() was not being called which could cause the delegate to be accessed after it was destroyed. - MediaSourceDelegate was signalling that it had metadata before the ChunkDemuxer was even initialized. This caused the HTMLMediaElement to signal that the load completed way too early and caused play() to be called when the delegate wasn't ready. BUG=233420 TEST=webkitmediasource-play.html LayoutTest reliably runs w/o crashing now. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202019

Patch Set 1 : Original patch #

Patch Set 2 : Make Destroy() public and remove friend decl to make compiler happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -15 lines) Patch
M media/base/android/demuxer_stream_player_params.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/base/android/media_source_player.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webkit/media/android/media_source_delegate.h View 1 5 chunks +17 lines, -4 lines 0 comments Download
M webkit/media/android/media_source_delegate.cc View 12 chunks +49 lines, -2 lines 0 comments Download
M webkit/media/android/webmediaplayer_android.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/media/android/webmediaplayer_android.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
acolwell GONE FROM CHROMIUM
The original version of this patch (https://codereview.chromium.org/15754004/) got reverted because of a compiler error on ...
7 years, 7 months ago (2013-05-23 17:09:46 UTC) #1
qinmin
lgtm
7 years, 7 months ago (2013-05-23 19:15:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/15898002/10001
7 years, 7 months ago (2013-05-23 19:18:18 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 07:58:54 UTC) #4
Message was sent while issue was closed.
Change committed as 202019

Powered by Google App Engine
This is Rietveld 408576698