Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 15897025: Add window.crypto.subtle behind a runtime feature flag ("Crypto") (Closed)

Created:
7 years, 6 months ago by eroman
Modified:
7 years, 6 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch, Ryan Sleevi
Visibility:
Public.

Description

Add window.crypto.subtle behind a runtime feature flag ("Crypto") BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152288

Patch Set 1 #

Patch Set 2 : Correct liscence header copied from Crypto.idl #

Patch Set 3 : Rebase on head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -26 lines) Patch
M Source/core/page/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/crypto/Crypto.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/modules/crypto/Crypto.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/modules/crypto/Crypto.idl View 1 chunk +7 lines, -0 lines 0 comments Download
A + Source/modules/crypto/SubtleCrypto.h View 3 chunks +6 lines, -8 lines 0 comments Download
A + Source/modules/crypto/SubtleCrypto.cpp View 2 chunks +11 lines, -13 lines 0 comments Download
A + Source/modules/crypto/SubtleCrypto.idl View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/modules.gypi View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eroman
7 years, 6 months ago (2013-06-11 22:54:08 UTC) #1
abarth-chromium
LGTM I could ask you for a test, but we can wait until you add ...
7 years, 6 months ago (2013-06-11 23:17:12 UTC) #2
eroman
Sounds good. I will introduce tests in my next CL once I start wiring things ...
7 years, 6 months ago (2013-06-11 23:58:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/15897025/7001
7 years, 6 months ago (2013-06-12 06:04:25 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=12428
7 years, 6 months ago (2013-06-12 06:24:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/15897025/7001
7 years, 6 months ago (2013-06-12 06:54:23 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-12 06:58:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/15897025/7001
7 years, 6 months ago (2013-06-12 16:32:22 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 16:57:57 UTC) #9
Message was sent while issue was closed.
Change committed as 152288

Powered by Google App Engine
This is Rietveld 408576698