Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: src/mips/lithium-codegen-mips.cc

Issue 15896038: Fix parallel recompilation wrt transition maps dependency. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.h ('k') | src/x64/lithium-codegen-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 void LCodeGen::FinishCode(Handle<Code> code) { 82 void LCodeGen::FinishCode(Handle<Code> code) {
83 ASSERT(is_done()); 83 ASSERT(is_done());
84 code->set_stack_slots(GetStackSlotCount()); 84 code->set_stack_slots(GetStackSlotCount());
85 code->set_safepoint_table_offset(safepoints_.GetCodeOffset()); 85 code->set_safepoint_table_offset(safepoints_.GetCodeOffset());
86 if (FLAG_weak_embedded_maps_in_optimized_code) { 86 if (FLAG_weak_embedded_maps_in_optimized_code) {
87 RegisterDependentCodeForEmbeddedMaps(code); 87 RegisterDependentCodeForEmbeddedMaps(code);
88 } 88 }
89 PopulateDeoptimizationData(code); 89 PopulateDeoptimizationData(code);
90 info()->CommitDependentMaps(code); 90 info()->CommitDependentMaps(code);
91 91
92 for (int i = 0 ; i < transition_maps_.length(); i++) {
93 transition_maps_.at(i)->AddDependentCode(
94 DependentCode::kTransitionGroup, code);
95 }
96 if (graph()->depends_on_empty_array_proto_elements()) { 92 if (graph()->depends_on_empty_array_proto_elements()) {
97 isolate()->initial_object_prototype()->map()->AddDependentCode( 93 isolate()->initial_object_prototype()->map()->AddDependentCode(
98 DependentCode::kElementsCantBeAddedGroup, code); 94 DependentCode::kElementsCantBeAddedGroup, code);
99 isolate()->initial_array_prototype()->map()->AddDependentCode( 95 isolate()->initial_array_prototype()->map()->AddDependentCode(
100 DependentCode::kElementsCantBeAddedGroup, code); 96 DependentCode::kElementsCantBeAddedGroup, code);
101 } 97 }
102 } 98 }
103 99
104 100
105 void LChunkBuilder::Abort(const char* reason) { 101 void LChunkBuilder::Abort(const char* reason) {
(...skipping 3859 matching lines...) Expand 10 before | Expand all | Expand 10 after
3965 } else if (FLAG_track_double_fields && representation.IsDouble()) { 3961 } else if (FLAG_track_double_fields && representation.IsDouble()) {
3966 ASSERT(transition.is_null()); 3962 ASSERT(transition.is_null());
3967 ASSERT(access.IsInobject()); 3963 ASSERT(access.IsInobject());
3968 ASSERT(!instr->hydrogen()->NeedsWriteBarrier()); 3964 ASSERT(!instr->hydrogen()->NeedsWriteBarrier());
3969 DoubleRegister value = ToDoubleRegister(instr->value()); 3965 DoubleRegister value = ToDoubleRegister(instr->value());
3970 __ sdc1(value, FieldMemOperand(object, offset)); 3966 __ sdc1(value, FieldMemOperand(object, offset));
3971 return; 3967 return;
3972 } 3968 }
3973 3969
3974 if (!transition.is_null()) { 3970 if (!transition.is_null()) {
3975 if (transition->CanBeDeprecated()) {
3976 transition_maps_.Add(transition, info()->zone());
3977 }
3978 __ li(scratch, Operand(transition)); 3971 __ li(scratch, Operand(transition));
3979 __ sw(scratch, FieldMemOperand(object, HeapObject::kMapOffset)); 3972 __ sw(scratch, FieldMemOperand(object, HeapObject::kMapOffset));
3980 if (instr->hydrogen()->NeedsWriteBarrierForMap()) { 3973 if (instr->hydrogen()->NeedsWriteBarrierForMap()) {
3981 Register temp = ToRegister(instr->temp()); 3974 Register temp = ToRegister(instr->temp());
3982 // Update the write barrier for the map field. 3975 // Update the write barrier for the map field.
3983 __ RecordWriteField(object, 3976 __ RecordWriteField(object,
3984 HeapObject::kMapOffset, 3977 HeapObject::kMapOffset,
3985 scratch, 3978 scratch,
3986 temp, 3979 temp,
3987 GetRAState(), 3980 GetRAState(),
(...skipping 1702 matching lines...) Expand 10 before | Expand all | Expand 10 after
5690 __ Subu(scratch, result, scratch); 5683 __ Subu(scratch, result, scratch);
5691 __ lw(result, FieldMemOperand(scratch, 5684 __ lw(result, FieldMemOperand(scratch,
5692 FixedArray::kHeaderSize - kPointerSize)); 5685 FixedArray::kHeaderSize - kPointerSize));
5693 __ bind(&done); 5686 __ bind(&done);
5694 } 5687 }
5695 5688
5696 5689
5697 #undef __ 5690 #undef __
5698 5691
5699 } } // namespace v8::internal 5692 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.h ('k') | src/x64/lithium-codegen-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698