Issue 15896025: Change --origin-port-to-force-quic-on to --origin-to-force-quic-on.

Issue 15896025: Change --origin-port-to-force-quic-on to --origin-to-force-quic-on. (Closed)

Created:
7 years, 6 months ago by Ryan Hamilton

Modified:
7 years, 6 months ago

Reviewers:
ramant (doing other things), Nico

CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, arv+watch_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change --origin-port-to-force-quic-on to --origin-to-force-quic-on. Instead of forcing QUIC on for all origins with the specified port, this will allow QUIC to be forced for a particular origin. The old flag made it challenging to test QUIC to servers on non-unique ports (like 80 or 443). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203842

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -19 lines)			Patch
M	chrome/browser/io_thread.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/io_thread.cc	View	2 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/net_internals/quic_view.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/http/http_network_session.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_network_session.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	net/http/http_stream_factory_impl_job.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_network_transaction_unittest.cc	View	3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

Nico: chrome/ rtenneti: net/ Should be a pretty quic (so clever) review, I think.

7 years, 6 months ago (2013-06-03 18:19:42 UTC) #1

Nico

code lgtm, cl description could be a bit more descriptive. For example, previously one could ...

7 years, 6 months ago (2013-06-03 18:28:10 UTC) #2

Ryan Hamilton

On 2013/06/03 18:28:10, Nico wrote: > code lgtm, cl description could be a bit more ...

7 years, 6 months ago (2013-06-03 18:30:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/15896025/1

7 years, 6 months ago (2013-06-03 19:15:00 UTC) #5

Message was sent while issue was closed.

Change committed as 203842

Expand Messages | Collapse Messages