Makes TabStripModel deal handle the case of the TabStripModel

Makes TabStripModel handle the case of the TabStripModel
being deleted while the TabStripModel is closing tabs. I suspect
is what is causing the crash.

BUG=241445
TEST=covered by test
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203846

[Ben Goodger (Google), 2013-06-03 18:14:41]

lgtm

[commit-bot: I haz the power, 2013-06-03 18:36:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/15896023/1

[Avi (use Gerrit), 2013-06-03 18:41:35]

Drive-by nitpicking.

https://codereview.chromium.org/15896023/diff/1/chrome/browser/ui/tabs/tab_st...
File chrome/browser/ui/tabs/tab_strip_model.cc (right):

https://codereview.chromium.org/15896023/diff/1/chrome/browser/ui/tabs/tab_st...
chrome/browser/ui/tabs/tab_strip_model.cc:53: typedef
std::vector<content::WebContents*> Contents;
Note that we have "using content::WebContents" above. You don't need to qualify
WebContents anywhere in this file.

https://codereview.chromium.org/15896023/diff/1/chrome/browser/ui/tabs/tab_st...
File chrome/browser/ui/tabs/tab_strip_model.h (right):

https://codereview.chromium.org/15896023/diff/1/chrome/browser/ui/tabs/tab_st...
chrome/browser/ui/tabs/tab_strip_model.h:462: // Conveniance for converting a
vector of indices into a vector of
typo: Convenience

https://codereview.chromium.org/15896023/diff/1/chrome/browser/ui/tabs/tab_st...
chrome/browser/ui/tabs/tab_strip_model.h:464: std::vector<content::WebContents*>
GetWebContentsFromIndicies(
typo: Indices

[commit-bot: I haz the power, 2013-06-03 18:48:05]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[sky, 2013-06-03 19:26:49]

I incorporated all of Avi's feedback. Thanks Avi.

[commit-bot: I haz the power, 2013-06-03 19:27:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/15896023/8003

[Avi (use Gerrit), 2013-06-03 19:32:06]

On 2013/06/03 19:26:49, sky wrote:
> I incorporated all of Avi's feedback. Thanks Avi.

TabStripModel bugs are the nastiest bugs. Thank you.

[commit-bot: I haz the power, 2013-06-04 04:31:53]

Change committed as 203846