Issue 15896012: Use SkBitmapOperations to extract a frame of animation cursors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15896012: Use SkBitmapOperations to extract a frame of animation cursors. (Closed)

Created:
7 years, 7 months ago by yoshiki

Modified:
7 years, 6 months ago

Reviewers:
commit-bot: I haz the power, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use SkBitmapOperations to extract a frame of animation cursors. r201206 caused a regression. It broke animation cursors, because SkBitmap.extractSubset() doesn't extract a frame of animation cursor image. This patch fixes the regression, using SkBitmapOperations::CreateTiledBitmap to extract a frame of animation image instead of SkBitmap.extractSubset(). BUG=126942 TEST=The wait cursor animates correctly. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202825

Patch Set 1 #

Patch Set 2 : rebase #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	ui/base/cursor/cursor_loader_x11.cc	View		1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/15896012/1

7 years, 6 months ago (2013-05-29 02:15:35 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 6 months ago (2013-05-29 02:49:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/15896012/20001

7 years, 6 months ago (2013-05-29 03:31:26 UTC) #5

Message was sent while issue was closed.

Change committed as 202825

Expand Messages | Collapse Messages