Issue 15894022: [Telemetry] Fix GetCommandLine after r203697.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15894022: [Telemetry] Fix GetCommandLine after r203697. (Closed)

Created:
7 years, 6 months ago by tonyg

Modified:
7 years, 6 months ago

Reviewers:
Owen Lin, nduca, dtu

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Fix GetCommandLine after r203697. BUG=None TEST=Ran a page cycler on linux NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203757

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/telemetry/telemetry/core/platform/posix_platform_backend.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/15894022/1

7 years, 6 months ago (2013-06-03 19:58:55 UTC) #3

owenlin_google

7 years, 6 months ago (2013-06-04 02:21:01 UTC) #5

Thanks. I missed this one when I tested the code.

On Tue, Jun 4, 2013 at 2:33 AM,  <tonyg@chromium.org> wrote:
> Reviewers: Owen Lin, nduca, Dave Tu,
>
> Description:
> [Telemetry] Fix GetCommandLine after r203697.
>
> BUG=None
> TEST=Ran a page cycler on linux
> NOTRY=True
>
> Please review this at https://codereview.chromium.org/15894022/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M tools/telemetry/telemetry/core/platform/posix_platform_backend.py
>
>
> Index: tools/telemetry/telemetry/core/platform/posix_platform_backend.py
> diff --git
> a/tools/telemetry/telemetry/core/platform/posix_platform_backend.py
> b/tools/telemetry/telemetry/core/platform/posix_platform_backend.py
> index
>
5073bb19b50daff2f9af1c871016c63fbfdff91f..248f4d5d53eeaca26500776ceb03201f2c5d1c44
> 100644
> --- a/tools/telemetry/telemetry/core/platform/posix_platform_backend.py
> +++ b/tools/telemetry/telemetry/core/platform/posix_platform_backend.py
> @@ -57,6 +57,6 @@ class
> PosixPlatformBackend(platform_backend.PlatformBackend):
>      return child_ids
>
>    def GetCommandLine(self, pid):
> -    command = self._GetPsOutput('command', pid)
> +    command = self._GetPsOutput(['command'], pid)
>      return command[0] if command else None
>
>
>



-- 
Owen Cheng-Ru Lin
Google Taipei Software Engineer

Expand Messages | Collapse Messages