Allow chrome trace to be collected when atrace is enabled.

Allow chrome trace to be collected when atrace is enabled.

Previously we chrome trace and atrace is exclusive. Sometimes this is
inconvenient.

BUG=244501
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202949

[dsinclair, 2013-05-29 13:49:19]

https://codereview.chromium.org/15892014/diff/1/base/debug/trace_event_impl.cc
File base/debug/trace_event_impl.cc (right):

https://codereview.chromium.org/15892014/diff/1/base/debug/trace_event_impl.c...
base/debug/trace_event_impl.cc:1119: if (!(*category_group_enabled &
CATEGORY_ENABLED))
Can we pull this out into a method?

if (!isCategoryEnabled(category_group_enabled))

Then a little comment saying, atrace and chrome://tracing are not mutually
exclusive, or something along those lines?

[Xianzhu, 2013-05-29 17:14:31]

PTAL.

https://codereview.chromium.org/15892014/diff/1/base/debug/trace_event_impl.cc
File base/debug/trace_event_impl.cc (right):

https://codereview.chromium.org/15892014/diff/1/base/debug/trace_event_impl.c...
base/debug/trace_event_impl.cc:1119: if (!(*category_group_enabled &
CATEGORY_ENABLED))
On 2013/05/29 13:49:20, dsinclair wrote:
> Can we pull this out into a method?
> 
> if (!isCategoryEnabled(category_group_enabled))
> 
> Then a little comment saying, atrace and chrome://tracing are not mutually
> exclusive, or something along those lines?

Done.

[dsinclair, 2013-05-29 17:17:11]

lgtm

[commit-bot: I haz the power, 2013-05-29 18:14:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/15892014/5001

[commit-bot: I haz the power, 2013-05-29 20:20:45]

Change committed as 202949