Issue 15892013: Make suggestions invalid when no phone number is attached to an address.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15892013: Make suggestions invalid when no phone number is attached to an address. (Closed)

Created:
7 years, 6 months ago by Dan Beam

Modified:
7 years, 6 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make suggestions invalid when no phone number is attached to a Wallet address/instrument. This is generally not applicable to autofill as we either filter out incomplete profiles or there's no associated phone number (in the case of credit cards). BUG=180149 R=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203068

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -5 lines)			Patch
M	chrome/browser/ui/autofill/data_model_wrapper.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/autofill/data_model_wrapper.cc	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/autofill/data_model_wrapper_unittest.cc	View	1 2	2 chunks	+22 lines, -0 lines	0 comments	Download
M	components/autofill/browser/wallet/wallet_address.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/15892013/5001

7 years, 6 months ago (2013-05-30 01:39:09 UTC) #3

Message was sent while issue was closed.

Change committed as 203068

Expand Messages | Collapse Messages