Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15892009: [Quota] Move quota related callbacks to separate file (Closed)

Created:
7 years, 7 months ago by tzik
Modified:
7 years, 6 months ago
CC:
chromium-reviews, tzik+watch_chromium.org, markusheintz_, darin-cc_chromium.org, kinuko+watch
Visibility:
Public.

Description

[Quota] Move quota related callbacks to separate file This CL splits out quota related callbacks to separate file. After this CL lands, quota_types.h is only depended file from non-browser directory. TBR=markusheintz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202547

Patch Set 1 #

Patch Set 2 : #include -> forward decl #

Patch Set 3 : +#include <algorithm> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -131 lines) Patch
M chrome/browser/browsing_data/browsing_data_quota_helper_impl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/syncable/canned_syncable_file_system.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/fileapi/file_system_util.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + webkit/quota/quota_callbacks.h View 2 chunks +4 lines, -17 lines 0 comments Download
M webkit/quota/quota_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/quota/quota_types.h View 2 chunks +1 line, -114 lines 0 comments Download
M webkit/quota/usage_tracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/quota/webkit_quota.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tzik
PTL
7 years, 7 months ago (2013-05-28 04:32:57 UTC) #1
kinuko
lgtm, thanks!
7 years, 7 months ago (2013-05-28 04:42:19 UTC) #2
tzik
TBRing markusheintz for adding the forward decl to chrome/browser/browsing_data/browsing_data_quota_helper_impl.h
7 years, 7 months ago (2013-05-28 05:04:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/15892009/4001
7 years, 7 months ago (2013-05-28 05:05:16 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-28 05:34:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/15892009/23001
7 years, 6 months ago (2013-05-28 07:37:55 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118935
7 years, 6 months ago (2013-05-28 10:05:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/15892009/23001
7 years, 6 months ago (2013-05-28 10:33:25 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 13:43:51 UTC) #9
Message was sent while issue was closed. 
Change committed as 202547

Powered by Google App Engine
This is Rietveld 408576698