Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 15891007: Revert "Add display API Documentations to Doc server" (Closed)

Created:
7 years, 6 months ago by not at google - send to devlin
Modified:
7 years, 6 months ago
Reviewers:
Hongbo Min
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert "Add display API Documentations to Doc server" It was unreviewed, should not have been TBR'd. Also broke the docserver so reverting rather than figuring out some kind of follow up. TBR=hongbo.min@intel.com BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
D chrome/common/extensions/docs/templates/public/apps/systemInfo_display.html View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/templates/public/extensions/experimental_systemInfo_cpu.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/extensions/experimental_systemInfo_storage.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/15891007/1
7 years, 6 months ago (2013-05-28 18:19:22 UTC) #1
commit-bot: I haz the power
Change committed as 202603
7 years, 6 months ago (2013-05-28 18:19:36 UTC) #2
Hongbo Min
Thanks for your follow-up. How do I know if a documentation change will break Doc ...
7 years, 6 months ago (2013-05-29 00:51:21 UTC) #3
not at google - send to devlin
7 years, 6 months ago (2013-05-29 00:53:18 UTC) #4
Message was sent while issue was closed.
The breakage was a bug in the docserver, nothing to do with your change.

Powered by Google App Engine
This is Rietveld 408576698