Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 15888011: Android WebView: add empty jarjar ruleset. (Closed)

Created:
7 years, 6 months ago by Torne
Modified:
7 years, 6 months ago
Reviewers:
bulach
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Android WebView: add empty jarjar ruleset. We don't have any jarjar rules yet, but add the empty file now in order that the downstream build can enable jarjar. This way, when rules are added later it will just work, instead of breaking the downstream build temporarily. Also, make sure that when a jarjar rule file is being used, it's considered as an input to the JNI generator step, to make sure the JNI header files get regenerated when the rules change. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203141

Patch Set 1 #

Total comments: 4

Patch Set 2 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, --1 lines) Patch
A + android_webview/build/jarjar-rules.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M build/common.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M build/jni_generator.gypi View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
7 years, 6 months ago (2013-05-30 10:23:04 UTC) #1
bulach
lgtm, just nits: https://codereview.chromium.org/15888011/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/15888011/diff/1/build/common.gypi#newcode1318 build/common.gypi:1318: 'jni_generator_jarjar_file': '../android_webview/build/jarjar-rules.txt', does it need a ...
7 years, 6 months ago (2013-05-30 10:50:35 UTC) #2
Torne
https://codereview.chromium.org/15888011/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/15888011/diff/1/build/common.gypi#newcode1318 build/common.gypi:1318: 'jni_generator_jarjar_file': '../android_webview/build/jarjar-rules.txt', On 2013/05/30 10:50:36, bulach wrote: > does ...
7 years, 6 months ago (2013-05-30 11:08:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/15888011/6001
7 years, 6 months ago (2013-05-30 11:28:48 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 14:16:23 UTC) #5
Message was sent while issue was closed.
Change committed as 203141

Powered by Google App Engine
This is Rietveld 408576698