Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 15885004: Adjust PrintPreview height. (Closed)

Created:
7 years, 7 months ago by Rune Fevang
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@constrained-signin
Visibility:
Public.

Description

Adjust PrintPreview height. Have the bottom margin of the print preview dialog be the same as the side margins (25 pixels). BUG=243275 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/printing/print_preview_dialog_controller.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Rune Fevang
7 years, 7 months ago (2013-05-24 22:38:35 UTC) #1
Mike Wittman
lgtm
7 years, 7 months ago (2013-05-24 22:57:37 UTC) #2
Vitaly Buka (NO REVIEWS)
On 2013/05/24 22:57:37, Mike Wittman wrote: > lgtm I applied patch and it works as ...
7 years, 7 months ago (2013-05-24 23:17:31 UTC) #3
Rune Fevang
On 2013/05/24 23:17:31, Vitaly Buka wrote: > On 2013/05/24 22:57:37, Mike Wittman wrote: > > ...
7 years, 7 months ago (2013-05-24 23:55:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/15885004/1
7 years, 7 months ago (2013-05-24 23:55:45 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-26 02:15:49 UTC) #6
Message was sent while issue was closed.
Change committed as 202330

Powered by Google App Engine
This is Rietveld 408576698