Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

Issue 15881006: Added 'error logs' tab to chrome://translte-internals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (Rebasing) Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
diff --git a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
index c9bdddd422bc17d1b254a21d9e1342ae9575bbac..3b2570e7341298c54878ac032065e7fd67d81e25 100644
--- a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
+++ b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
@@ -12,6 +12,7 @@
#include "base/prefs/pref_service.h"
#include "base/values.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/translate/translate_error_details.h"
#include "chrome/browser/translate/translate_prefs.h"
#include "chrome/common/language_detection_details.h"
#include "chrome/common/pref_names.h"
@@ -50,6 +51,18 @@ void TranslateInternalsHandler::OnLanguageDetection(
SendMessageToJs("languageDetectionInfoAdded", dict);
}
+void TranslateInternalsHandler::OnTranslateError(
+ const TranslateErrorDetails& details) {
+ base::DictionaryValue dict;
+ dict.Set("time",
+ new base::FundamentalValue(details.time.ToJsTime()));
+ dict.Set("url",
+ new base::StringValue(details.url.spec()));
+ dict.Set("error",
+ new base::FundamentalValue(details.error));
+ SendMessageToJs("translateErrorDetailsAdded", dict);
+}
+
void TranslateInternalsHandler::OnRemovePrefItem(const base::ListValue* args) {
content::WebContents* web_contents = web_ui()->GetWebContents();
Profile* profile =
« no previous file with comments | « chrome/browser/ui/webui/translate_internals/translate_internals_handler.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698