|
Use DownloadItem::GetState() in c/b/{download,extensions}
Stop using DownloadItem::Is*() functions that have an equivalent
state exposed via GetState(). Rationale is that there shouldn't be
multiple ways of getting the same state information.
To make review easier, this patch covers chrome/browser/download
and chrome/browser/extensions. The remaining cases and changing
the DownloadItem to remove the Is*() functions will come later.
BUG= 241141
TEST=browser_tests and unit_tests both with *Download*:*SavePage* filters
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202229
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+84 lines, -100 lines) |
Patch |
|
M |
chrome/browser/download/chrome_download_manager_delegate.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/chrome_download_manager_delegate_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_browsertest.cc
|
View
|
|
4 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_danger_prompt.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_danger_prompt_browsertest.cc
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_item_model.cc
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_item_model_unittest.cc
|
View
|
|
3 chunks |
+0 lines, -12 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_shelf.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_shelf_context_menu.cc
|
View
|
1
|
3 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_shelf_unittest.cc
|
View
|
|
3 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_status_updater.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_status_updater_unittest.cc
|
View
|
|
2 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_target_determiner.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_target_determiner_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_ui_controller.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_ui_controller_unittest.cc
|
View
|
1
|
3 chunks |
+6 lines, -15 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_util.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/download/save_page_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/downloads/downloads_api.cc
|
View
|
1
|
3 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/downloads/downloads_api_unittest.cc
|
View
|
|
24 chunks |
+27 lines, -27 lines |
0 comments
|
Download
|
Total messages: 9 (0 generated)
|