Support web contents modal dialogs within SimpleWebViewDialog and WebUILoginView

Support web contents modal dialogs within SimpleWebViewDialog and WebUILoginView

These two dialogs host web contents modal dialogs on their WebContents,
so they need to implement the WebContentsModalDialogManagerDelegate
and WebContentsModalDialogHost interfaces to provide dialog host view
and positioning.

BUG=244173
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202948

[Mike Wittman, 2013-05-28 23:34:06]

Hi Yuri, please take a look.

Note that I have not tested these changes.  I was able to create the login
dialog using "chrome --login-manager" after configuring with -Dchromeos=1, but
I'm unsure how to trigger connection to network which requires proxy auth.  Also
I get an assertion failure in ProfileManager::GetProfileDir() at line 350 when
trying to log in.

Could you do one of the following:
 - let me know how to test both the SimpleWebViewDialog and WebUILoginView
dialogs under Linux, or
 - manually test this CL and let me know what additional changes are required,
if any, or
 - adopt these changes yourself and shepherd through the review process

Thanks!

[ygorshenin1, 2013-05-29 08:09:25]

lgtm with nit, checked on Linux ChromeOS build, works perfectly.

https://codereview.chromium.org/15879007/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/simple_web_view_dialog.cc (right):

https://codereview.chromium.org/15879007/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/simple_web_view_dialog.cc:374: }
Please, add check for |observer|:
if (observer && !observer_list_.HasObserver(observer))
  observer_list_.AddObserver(observer);

[commit-bot: I haz the power, 2013-05-29 16:30:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wittman@chromium.org/15879007/12001

[commit-bot: I haz the power, 2013-05-29 20:18:23]

Change committed as 202948