Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 15878007: Adjust the thumbnail view to match the specs. (Closed)

Created:
7 years, 6 months ago by mtomasz
Modified:
7 years, 6 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Adjust the thumbnail view to match the specs. This patch adjusts the grid view's styles to match the recent specs by removing checkbox and making the label transparent. Along the way, the redundant border (from webui) has been hidden. TBR=yoshiki@chromium.org TEST=Go to Files.app, enter a directory with images. Switch to the grid view. BUG=239288 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202802

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed. #

Total comments: 2

Patch Set 3 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -13 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 2 5 chunks +33 lines, -12 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_grid.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mtomasz
@hirono: PTAL. Thanks.
7 years, 6 months ago (2013-05-28 07:45:43 UTC) #1
hirono
https://codereview.chromium.org/15878007/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://codereview.chromium.org/15878007/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode1210 chrome/browser/resources/file_manager/css/file_manager.css:1210: margin-left: 8px; "-webkit-margin-start: 8px;" ? https://codereview.chromium.org/15878007/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode1268 chrome/browser/resources/file_manager/css/file_manager.css:1268: text-align: left; ...
7 years, 6 months ago (2013-05-28 08:28:36 UTC) #2
mtomasz
https://codereview.chromium.org/15878007/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://codereview.chromium.org/15878007/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode1210 chrome/browser/resources/file_manager/css/file_manager.css:1210: margin-left: 8px; On 2013/05/28 08:28:36, hirono wrote: > "-webkit-margin-start: ...
7 years, 6 months ago (2013-05-28 09:16:04 UTC) #3
hirono
https://codereview.chromium.org/15878007/diff/4001/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://codereview.chromium.org/15878007/diff/4001/chrome/browser/resources/file_manager/css/file_manager.css#newcode1267 chrome/browser/resources/file_manager/css/file_manager.css:1267: padding-left: 28px; -webkit-padding-start ?
7 years, 6 months ago (2013-05-28 09:35:11 UTC) #4
mtomasz
https://codereview.chromium.org/15878007/diff/4001/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://codereview.chromium.org/15878007/diff/4001/chrome/browser/resources/file_manager/css/file_manager.css#newcode1267 chrome/browser/resources/file_manager/css/file_manager.css:1267: padding-left: 28px; On 2013/05/28 09:35:11, hirono wrote: > -webkit-padding-start ...
7 years, 6 months ago (2013-05-28 09:48:27 UTC) #5
hirono
On 2013/05/28 09:48:27, mtomasz wrote: > https://codereview.chromium.org/15878007/diff/4001/chrome/browser/resources/file_manager/css/file_manager.css > File chrome/browser/resources/file_manager/css/file_manager.css (right): > > https://codereview.chromium.org/15878007/diff/4001/chrome/browser/resources/file_manager/css/file_manager.css#newcode1267 > ...
7 years, 6 months ago (2013-05-28 09:59:46 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 6 months ago (2013-05-28 10:08:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/15878007/11001
7 years, 6 months ago (2013-05-29 02:54:13 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 07:45:00 UTC) #9
Message was sent while issue was closed.
Change committed as 202802

Powered by Google App Engine
This is Rietveld 408576698