Popup menu is not aligned with the select element if inside a transformed webview.

Popup menu is not aligned with the select element if inside a transformed webview.

When translating the quad of the select element position, each corner needs to be calculated seperately, instead of moving all corners together.
BUG=154992
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152023

[yael.aharon1, 2013-06-06 13:56:53]

I tested manually with all the corner cases that I could think of, but I am not
sure how to write an automated test for this. Any advice would be appreciated.

[lazyboy, 2013-06-06 15:15:53]

On 2013/06/06 13:56:53, yael.aharon1 wrote:
> I tested manually with all the corner cases that I could think of, but I am
not
> sure how to write an automated test for this. Any advice would be appreciated.

I believe you need LayoutTest for this, similar to:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[yael.aharon1, 2013-06-06 15:31:04]

On 2013/06/06 15:15:53, lazyboy wrote:
> On 2013/06/06 13:56:53, yael.aharon1 wrote:
> > I tested manually with all the corner cases that I could think of, but I am
> not
> > sure how to write an automated test for this. Any advice would be
appreciated.
> 
> I believe you need LayoutTest for this, similar to:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Thank you for the suggestion, but I don't think that I can use layout tests.
layout tests don't have support for checking the position of the popup menu and
I was asked before not to add that. (Since mac uses external popup and will not
be covered).

[tkent, 2013-06-07 03:16:52]

lgtm.

Unfortunately this is not testable for now.

https://codereview.chromium.org/15877005/diff/1/Source/WebKit/chromium/src/Po...
File Source/WebKit/chromium/src/PopupContainer.cpp (right):

https://codereview.chromium.org/15877005/diff/1/Source/WebKit/chromium/src/Po...
Source/WebKit/chromium/src/PopupContainer.cpp:390:
m_controlPosition.setP1(v->contentsToWindow(IntPoint(controlPosition.p1().x(),
controlPosition.p1().y())));
Would you add a comment about a reason why we need to convert each of points?

[commit-bot: I haz the power, 2013-06-07 12:01:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/15877005/9001

[commit-bot: I haz the power, 2013-06-07 12:48:36]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-06-07 12:53:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/15877005/9001

[commit-bot: I haz the power, 2013-06-07 14:11:34]

Change committed as 152023