Forwarding app URL to handler host for WebRTC logs.

Forwarding app URL to handler host for WebRTC logs.

BUG=229829
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202426

[Henrik Grunell, 2013-05-23 14:54:34]

This will be used in a later CL.

Ken: content/common/*
Tommi: All

[kenrb, 2013-05-24 20:46:11]

On 2013/05/23 14:54:34, Henrik Grunell wrote:
> This will be used in a later CL.
> 
> Ken: content/common/*
> Tommi: All

lgtm

[tommi (sloooow) - chröme, 2013-05-25 11:44:03]

https://codereview.chromium.org/15875005/diff/1/content/renderer/media/media_...
File content/renderer/media/media_stream_dependency_factory.cc (right):

https://codereview.chromium.org/15875005/diff/1/content/renderer/media/media_...
content/renderer/media/media_stream_dependency_factory.cc:513: std::string url =
web_frame->document().url().spec().data();
why call data()?  using std::string's copy constructor might be better but I'm
curious why you need to bypass that.

[Henrik Grunell, 2013-05-27 11:21:50]

Code review fix.

webrtc_logging_handler_host.cc is rebase change only.

https://chromiumcodereview.appspot.com/15875005/diff/1/content/renderer/media...
File content/renderer/media/media_stream_dependency_factory.cc (right):

https://chromiumcodereview.appspot.com/15875005/diff/1/content/renderer/media...
content/renderer/media/media_stream_dependency_factory.cc:513: std::string url =
web_frame->document().url().spec().data();
On 2013/05/25 11:44:04, tommi wrote:
> why call data()?  using std::string's copy constructor might be better but I'm
> curious why you need to bypass that.

That's totally unnecessary, I just didn't notice the operator in WebCString.
Thanks. Fixed.

[tommi (sloooow) - chröme, 2013-05-27 11:33:32]

lgtm

https://chromiumcodereview.appspot.com/15875005/diff/1/content/renderer/media...
File content/renderer/media/media_stream_dependency_factory.cc (right):

https://chromiumcodereview.appspot.com/15875005/diff/1/content/renderer/media...
content/renderer/media/media_stream_dependency_factory.cc:513: std::string url =
web_frame->document().url().spec().data();
On 2013/05/27 11:21:50, Henrik Grunell wrote:
> On 2013/05/25 11:44:04, tommi wrote:
> > why call data()?  using std::string's copy constructor might be better but
I'm
> > curious why you need to bypass that.
> 
> That's totally unnecessary, I just didn't notice the operator in WebCString.
> Thanks. Fixed.

Sorry, I actually thought I was looking at a GURL variable, so I was expecting
spec() to return std::string. My bad.

[Henrik Grunell, 2013-05-27 12:27:32]

On 2013/05/27 11:33:32, tommi wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/15875005/diff/1/content/renderer/media...
> File content/renderer/media/media_stream_dependency_factory.cc (right):
> 
>
https://chromiumcodereview.appspot.com/15875005/diff/1/content/renderer/media...
> content/renderer/media/media_stream_dependency_factory.cc:513: std::string url
=
> web_frame->document().url().spec().data();
> On 2013/05/27 11:21:50, Henrik Grunell wrote:
> > On 2013/05/25 11:44:04, tommi wrote:
> > > why call data()?  using std::string's copy constructor might be better but
> I'm
> > > curious why you need to bypass that.
> > 
> > That's totally unnecessary, I just didn't notice the operator in WebCString.
> > Thanks. Fixed.
> 
> Sorry, I actually thought I was looking at a GURL variable, so I was expecting
> spec() to return std::string. My bad.

Well it turned out to be better removed anyway... :)

[commit-bot: I haz the power, 2013-05-27 12:28:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grunell@chromium.org/15875005/12001

[commit-bot: I haz the power, 2013-05-27 14:42:54]

Change committed as 202426