Max-width, floating infobars.

Max-width, floating infobars.

This adds a width restriction on infobars. If the webpage is wider than
the infobar max width (600dp), the infobars will "float" in the middle
bottom of the page with shadows on the left, top, and right edges of
each infobar.

BUG=396223
Committed: https://crrev.com/09a677695eeb5a3631cf50386cbb612e3da0b833
Cr-Commit-Position: refs/heads/master@{#370740}

[newt (away), 2016-01-15 01:08:23]

newt@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[newt (away), 2016-01-15 01:08:23]

newt@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[newt (away), 2016-01-15 01:08:23]

PTAL

[newt (away), 2016-01-15 01:08:23]

PTAL

[newt (away), 2016-01-15 01:13:39]

Note: assets aren't finalized (only xxhdpi versions are available currently,
waiting on the other resolutions)

Summary of changes:
 - Converted infobar_wrapper.xml into InfobarWrapper.java.
 - Renamed "fooView" -> "fooWrapper" and "fooInnerView" -> "fooContents" in
InfoBarContainerLayout.
 - Removed calls to getChildCount() and getChildAt(). IBCL now uses a list
(mInfoBarWrappers) to keep track of its wrapper views. This makes it possible
add other views to the IBCL (i.e. shadow views).
 - Added FloatingBehavior, of course.
 - Funneled all y-translation animations through createTranslationYAnimator() to
ensure that shadow positions are updated during animations.

[gone, 2016-01-15 22:48:38]

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
File chrome/android/java/res/drawable/infobar_wrapper_bg.xml (right):

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
chrome/android/java/res/drawable/infobar_wrapper_bg.xml:14: android:top="9dp"
Should this value be replaced with @drawable/infobar_shadow_top?

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainerLayout.java
(right):

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainerLayout.java:587:
private final int mBackInfobarHeight;
nit: move the private final upwards?

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainerLayout.java:670:
view.setTranslationY((float) animation.getAnimatedValue());
is it really necessary to set the translation manually on the view here?  was
this the workaround for the shadow being out of sync?

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarWrapper.java
(right):

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarWrapper.java:16:
* Layout that holds infobar contents and provides a background color and a top
shadow.
an infobar's contents?

[newt (away), 2016-01-15 23:47:33]

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
File chrome/android/java/res/drawable/infobar_wrapper_bg.xml (right):

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
chrome/android/java/res/drawable/infobar_wrapper_bg.xml:14: android:top="9dp"
On 2016/01/15 22:48:38, dfalcantara wrote:
> Should this value be replaced with @drawable/infobar_shadow_top?

Do you mean @dimen/infobar_shadow_height? If so, yes :)

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainerLayout.java
(right):

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainerLayout.java:587:
private final int mBackInfobarHeight;
On 2016/01/15 22:48:38, dfalcantara wrote:
> nit: move the private final upwards?

Done.

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainerLayout.java:670:
view.setTranslationY((float) animation.getAnimatedValue());
On 2016/01/15 22:48:38, dfalcantara wrote:
> is it really necessary to set the translation manually on the view here?  was
> this the workaround for the shadow being out of sync?

Yes, it's necessary. The ValueAnimator I've created doesn't actually change any
state (except via this AnimatorUpdateListener). In fact, the ValueAnimator
doesn't know about the View at all; note the constructor:
"ValueAnimator.ofFloat(view.getTranslationY(), endValue)".

So, the AnimatorUpdateListener needs to update both the InfoBarWrapper's
position and the shadow's position.

Backstory: originally, I was using an ObjectAnimator to animate the
InfoBarWrapper's position, and an AnimatorUpdateListener to update the shadow
position on each frame. The problem was, the AnimatorUpdateListener actually
gets called *before* the ObjectAnimator has updated the position of the
InfoBarWrapper. Strange but -- read the code -- it's true. That was causing the
shadow position to be out of sync with the wrapper position. So, my fix was to
stop using ObjectAnimator; use the ValueAnimator superclass instead and update
both views' positions myself so that I can guarantee the updates happen in the
right order.

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarWrapper.java
(right):

https://chromiumcodereview.appspot.com/1587403002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarWrapper.java:16:
* Layout that holds infobar contents and provides a background color and a top
shadow.
On 2016/01/15 22:48:38, dfalcantara wrote:
> an infobar's contents?

More better grammar.

https://chromiumcodereview.appspot.com/1587403002/diff/60001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainerLayout.java
(right):

https://chromiumcodereview.appspot.com/1587403002/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainerLayout.java:438:
ObjectAnimator.ofFloat(InfoBarContainerLayout.this, View.TRANSLATION_Y,
A regular ObjectAnimator is fine here, since we're animating the whole
InfoBarContainerLayout

[gone, 2016-01-16 00:11:57]

lgtm

[newt (away), 2016-01-16 00:23:58]

Danke!

Just waiting for assets now...

[newt (away), 2016-01-20 21:54:30]

The CQ bit was checked by newt@chromium.org

[newt (away), 2016-01-20 21:54:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1587403002/#ps100001
(title: "final shadow assets and dimens")

[commit-bot: I haz the power, 2016-01-20 21:54:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587403002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587403002/100001

[newt (away), 2016-01-20 21:56:45]

Assets have arrived! Landing now...

[commit-bot: I haz the power, 2016-01-20 22:36:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 22:36:27]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[newt (away), 2016-01-21 18:17:17]

The CQ bit was checked by newt@chromium.org

[newt (away), 2016-01-21 18:17:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1587403002/#ps120001
(title: "suppress lint warning about using left/right instead of start/end for
shadows")

[commit-bot: I haz the power, 2016-01-21 18:17:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587403002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587403002/120001

[commit-bot: I haz the power, 2016-01-21 18:58:38]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-01-21 18:59:53]

Description was changed from

==========
Max-width, floating infobars.

This adds a width restriction on infobars. If the webpage is wider than
the infobar max width (600dp), the infobars will "float" in the middle
bottom of the page with shadows on the left, top, and right edges of
each infobar.

BUG=396223
==========

to

==========
Max-width, floating infobars.

This adds a width restriction on infobars. If the webpage is wider than
the infobar max width (600dp), the infobars will "float" in the middle
bottom of the page with shadows on the left, top, and right edges of
each infobar.

BUG=396223

Committed: https://crrev.com/09a677695eeb5a3631cf50386cbb612e3da0b833
Cr-Commit-Position: refs/heads/master@{#370740}
==========

[commit-bot: I haz the power, 2016-01-21 18:59:54]

Patchset 7 (id:??) landed as
https://crrev.com/09a677695eeb5a3631cf50386cbb612e3da0b833
Cr-Commit-Position: refs/heads/master@{#370740}