Disable preroll duration increase on underflow for MediaSource playback.

Disable preroll duration increase on underflow for MediaSource playback.

BUG=244334
TEST=None. Underflow covered by existing tests.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203917

[scherkus (not reviewing), 2013-06-03 21:53:34]

WDYT about making this a property of AudioRenderer(Impl) instead of plumbing
through Pipeline?

There's only one production call to ResumeAfterUnderflow() that has "true"
hardcoded, which was added in the original CL in http://crrev.com/106784

I questioned it then but you mentioned we'd need it soon :)
https://codereview.chromium.org/8356022/diff/1/media/base/filters.h

[acolwell GONE FROM CHROMIUM, 2013-06-03 22:29:48]

On 2013/06/03 21:53:34, scherkus wrote:
> WDYT about making this a property of AudioRenderer(Impl) instead of plumbing
> through Pipeline?
> 
> There's only one production call to ResumeAfterUnderflow() that has "true"
> hardcoded, which was added in the original CL in http://crrev.com/106784
> 
> I questioned it then but you mentioned we'd need it soon :)
> https://codereview.chromium.org/8356022/diff/1/media/base/filters.h

Sure since it isn't likely that I'm going to actually implement the predecode
underflow handling mentioned in the comment anytime soon.

[scherkus (not reviewing), 2013-06-03 22:52:17]

lgtm w/ nits

I also think you need to fix some compile failures (player_x11?)

https://codereview.chromium.org/15872004/diff/7001/media/filters/audio_render...
File media/filters/audio_renderer_impl.h (right):

https://codereview.chromium.org/15872004/diff/7001/media/filters/audio_render...
media/filters/audio_renderer_impl.h:57: //                                
should be increased when
nit: I never bother w/ this style of indentation, favouring vertical spacing
instead

horizontal whitespace is a scarce 80 chars, whereas vertical whitespace is cheap
;)

[acolwell GONE FROM CHROMIUM, 2013-06-03 23:01:34]

https://codereview.chromium.org/15872004/diff/7001/media/filters/audio_render...
File media/filters/audio_renderer_impl.h (right):

https://codereview.chromium.org/15872004/diff/7001/media/filters/audio_render...
media/filters/audio_renderer_impl.h:57: //                                
should be increased when
On 2013/06/03 22:52:17, scherkus wrote:
> nit: I never bother w/ this style of indentation, favouring vertical spacing
> instead
> 
> horizontal whitespace is a scarce 80 chars, whereas vertical whitespace is
cheap
> ;)

Done.

[commit-bot: I haz the power, 2013-06-03 23:01:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/15872004/11001

[commit-bot: I haz the power, 2013-06-04 00:27:08]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-06-04 01:18:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/15872004/11001

[commit-bot: I haz the power, 2013-06-04 10:50:10]

Change committed as 203917