Source/core/dom/shadow/ShadowRoot.cpp - Issue 15871005: Avoid N^2 walk placing renderers when building the render tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/ShadowRoot.cpp

Issue 15871005: Avoid N^2 walk placing renderers when building the render tree (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding a mitigation for the perf regression to Element::recalcStyle. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/shadow/ShadowRoot.cpp

diff --git a/Source/core/dom/shadow/ShadowRoot.cpp b/Source/core/dom/shadow/ShadowRoot.cpp

index 52165d642d8096e7dac09604f290e2713fb5927b..3655c2e9a00f2beec39fb41b696e497f36f8739e 100644

--- a/Source/core/dom/shadow/ShadowRoot.cpp

+++ b/Source/core/dom/shadow/ShadowRoot.cpp

@@ -164,7 +164,7 @@ void ShadowRoot::recalcStyle(StyleChange change)

if (styleChangeType() == FullStyleChange)

change = Force;

- for (Node* child = firstChild(); child; child = child->nextSibling()) {

+ for (Node* child = lastChild(); child; child = child->previousSibling()) {

if (child->isElementNode())

toElement(child)->recalcStyle(change);

else if (child->isTextNode())

« no previous file with comments | « Source/core/dom/Text.cpp ('k') | Source/core/html/HTMLInputElement.h » ('j') | no next file with comments »